Closed Bug 1412301 Opened 7 years ago Closed 7 years ago

[PWA] PWA doesn't always open in standalone mode

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

ARM
Android
defect

Tracking

(fennec+, firefox56 unaffected, firefox57 unaffected, firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
fennec + ---
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- verified

People

(Reporter: ohorvath, Assigned: droeh)

References

Details

Attachments

(2 files)

Device: Samsung Galaxy S8 (Android 7.0)
Build: Nightly 58.0a1 (2017-10-27);

Steps to reproduce:
1. Add to the home screen a PWA: e.g.pokedex.org, code.nasa.gov, etc.
2. As soon as the shortcut is displayed on the homescreen, tap and open the PWA.

Expected result:
The PWA should be launched as a standalone app.

Actual result:
The PWA is at first opened in a new tab. At the second launch, it opens in standalone mode. Not 100% reproducible, not even with the same apps.
See Also: → 1400605
Attached video recording.mp4
In this recording you can see I've had multiple pwa's already opened, I added the Notes PWA and it opened in a new tab at first.
Most likely we're just trying to start the app before the manifest is written to disk, probably due to the use of JSONFile.saveSoon in Manifest.jsm. I'll see what our options are.
Priority: -- → P2
tracking-fennec: ? → +
I think this should fix it; we just need to reduce the save delay to make sure the manifest is actually written to disk before we try to run the corresponding PWA.
Assignee: nobody → droeh
Attachment #8924191 - Flags: review?(snorp)
Attachment #8924191 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8b5f0c97d03
Decrease save delay to ensure PWA manifests are actually written to disk before a user tries to run one. r=snorp
https://hg.mozilla.org/mozilla-central/rev/e8b5f0c97d03
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
The issue is fixed on latest Nightly 58 (2017-11-03).
Verified on devices:
Samsung S7 Edge (Android 7.0)
Huawei Honor 5X (Android 5.1.1)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: