Closed Bug 1412333 Opened 3 years ago Closed 4 months ago

[Linux] Screen share selection on dual monitors - only "entire screen" option available

Categories

(Core :: WebRTC, defect, P3)

All
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1607238
Tracking Status
firefox-esr52 --- affected
firefox56 --- affected
firefox57 --- affected
firefox58 --- affected

People

(Reporter: aflorinescu, Assigned: dminor)

References

(Blocks 1 open bug)

Details

[Steps:]
1. Have dual monitors and open FF.
2. Open https://jsfiddle.net/pehrsons/7kgvL48e/ ,select Video/Screen and press Start.
3. An identity panel pop-up will be shown to select the screen to share(record).
4. Select Entire screen and "Allow".

[Actual Result:]
3. The options Screen 1 / Screen 2 is missing, being replaced by "Entire screen"
4. The recording will capture and record both screens in a 3840x1080 resolution. 

[Note1:]
Please see upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=437507.
Blocks: 1412341
jib, is this something you know of? Maybe somewhere to dupe this one?
Rank: 25
Flags: needinfo?(jib)
Priority: -- → P3
Looks like an upstream issue. Unfortunately, the upstream issue was closed as WontFix for what seems like poor reasons, judging by the subsequent activity. Maybe we should file a new bug?

Dan, any thoughts?
Flags: needinfo?(jib) → needinfo?(dminor)
Someone filed a new bug back in 2016 as https://bugs.chromium.org/p/chromium/issues/detail?id=660032 which doesn't seem to have been prioritized yet. If we want this fixed, I'm guessing the best bet would be to do the work ourselves and upstream it.

Looking at the code it seems like the relevant functions (ScreenCapturerLinux::GetSourceList and ScreenCapturerLinux::SelectSource) are just not implemented. I'm not sure offhand how much work would be involved in writing these, but I'd be willing to take a look when I have a chance, assuming we're happy with this being a P3.
Flags: needinfo?(dminor)
Assignee: nobody → dminor
I'm not sure if it's related to this bug, but I also can't select a single window to share.
Only the entire desktop is offered in the dropdown.

Browser: Firefox 58
OS: Debian buster (testing)
Architecture: amd64
Desktop: Plasma5/Xorg
Package: firefox-58.0.1-1+b1 from the Debian repos

Until this issue is fixed, here https://github.com/Ashark/hliss is good script with quick workaround for this problem to share only one screen via Firefox on Linux with multiple monitors setup.

And here https://bugs.chromium.org/p/chromium/issues/detail?id=396091 is same issue in Chromium thread.

Duplicate of this bug: 1612171

Related patch on Chromium hasn't been reverted since a month ago this time. Let's hope it sticks!

https://bugs.chromium.org/p/chromium/issues/detail?id=396091#c74

Good news! Just tested out with the latest Chrome Dev release, it works!!!

  • Chrome Dev Versione 83.0.4093.3 (Official Build) dev (64 bit)
  • Ubuntu 18.04.1 freshly installed and updated last friday (2020-03-27)

What do we need to do to have it here? Just pull from WebRTC upstream?

Related patch on Chromium hasn't been reverted since a month ago this time. Let's hope it sticks!

Sticks to Firefox code? =)

Does same code from Chrome can be reused in Firefox, or it use different implementation?

I was talking about "sticks to Chromium code", since the patch got reverted multiple times due to downstream tests breakage ;)

I don't know Firefox's codebase, if it uses WebRTC it should just be able to use it as is pulling from upstream.

@jib? @dminor? Can you weight in here?

Flags: needinfo?(dminor)

Upstream commit is: https://webrtc.googlesource.com/src.git/+/e952b78c283f5e54376561f7c7dd1460143c6112. We should be able to cherry pick it and apply to our local copy. I'll have a look.

Flags: needinfo?(dminor)

Unfortunately, taking these changes will have to wait until we do our next import of libwebrtc.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1607238
Duplicate of this bug: 1635366
You need to log in before you can comment on or make changes to this bug.