Open
Bug 1413133
Opened 7 years ago
Updated 2 years ago
Windows window snap state not restored for Thunderbird
Categories
(Thunderbird :: OS Integration, defect)
Tracking
(thunderbird_esr60 affected, thunderbird60 affected)
NEW
People
(Reporter: staneck, Unassigned)
References
Details
(Keywords: regression, regressionwindow-wanted)
Attachments
(1 file)
77.97 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.18 Safari/537.36
Steps to reproduce:
I have a multi (3) monitor setup, not sure how relevant this is.
Snap Thunderbird to a window edge, I used the left side, so WindowsKey+Left Arrow to do that. I have Thundebird on the right one of the 3 monitors.
Shutdown your computer
Start your computer
Start Thunderbird
Actual results:
Thunderbird was not exactly snapped to the edge anymore, instead it was a few pixels away from the edge.
Expected results:
Thunderbird should have restored in the snapped state.
Comment 1•7 years ago
|
||
Does Firefox store the snapped state? If not, please file a bug for Firefox or move this bug to the Firefox queue.
Thunderbird uses window management from common Mozilla core modules. I could well imagine that the window size and position is reinstated but not the snap state.
Comment 2•7 years ago
|
||
(In reply to Jorg K [Almost not working on Thunderbird (some bustage-fix only) due to non-renewal of contract] from comment #1)
> Does Firefox store the snapped state? If not, please file a bug for Firefox
> or move this bug to the Firefox queue.
>
> Thunderbird uses window management from common Mozilla core modules. I could
> well imagine that the window size and position is reinstated but not the
> snap state.
stan?
Flags: needinfo?(staneck)
Sorry, missed the reply. Firefox does in fact restore the snap state correctly. It seems to have some special code to do it. If I start it up again after closing, it restores in the "wrong" position but then snaps itself back into position after a split second.
Flags: needinfo?(staneck)
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Version: 58 Branch → 59
Comment 5•7 years ago
|
||
Rob can you reproduce?
If so, please change status to new
Blocks: tb60found
Flags: needinfo?(rob.smeets)
Summary: Windows window snap state not restored → Windows window snap state not restored for Thunderbird
Updated•7 years ago
|
Flags: needinfo?(rob.smeets)
Who would be able to confirm this? I can still repro it on 61.0a1 (2018-03-21) (64-bit).
Flags: needinfo?(vseerror)
Comment 7•7 years ago
|
||
I can't but maybe rctgamer3 can
Flags: needinfo?(vseerror) → needinfo?(rctgamer3)
Tested this with both Thunderbird and Firefox. Both reopen a couple of pixels from the screen border (likely default Windows behaviour, probably the window size + shadow width). However, Firefox fixes this, but Thunderbird doesn't.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(rctgamer3)
Yeah that is exactly what I am seeing. Thanks for confirming.
Comment 10•7 years ago
|
||
Richard, any idea where we should start looking?
Flags: needinfo?(richard.marti)
Comment 11•7 years ago
|
||
Unfortunately not. Maybe a regression window where FX was fixed or TB regressed could help.
Flags: needinfo?(richard.marti)
Comment 12•7 years ago
|
||
Jim, are you aware of any code in Firefox that deals with the window snap state that we could port to TB? Looks like FF is handling it well and TB doesn't.
Flags: needinfo?(jmathies)
Comment 13•6 years ago
|
||
Can you reproduce with nightly from https://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-central/ ?
Find a regression range?
Severity: normal → minor
status-thunderbird60:
--- → affected
status-thunderbird_esr60:
--- → affected
Flags: needinfo?(rctgamer3)
Reporter | ||
Comment 14•6 years ago
|
||
I tested with a recent nightly (62.0a1 (2018-05-19) (64-bit)) and it is still broken there.
Comment 15•6 years ago
|
||
important |
(In reply to Jorg K (GMT+2) (bustage-fix only, NI for urgent reviews) from comment #12)
> Jim, are you aware of any code in Firefox that deals with the window snap
> state that we could port to TB? Looks like FF is handling it well and TB
> doesn't.
it's all down in nsWindow, I'd suggest turning on the native message debugging and looking at that code for clues.
Flags: needinfo?(jmathies)
Reporter | ||
Comment 17•6 years ago
|
||
Still broken with 63.0a1 (2018-07-25) (64-bit)
Comment 18•6 years ago
|
||
I think I have seen this as well, slightly different, but it could be the same issue.
Thunderbird 60.0 64-bit on windows. Start with a new profile by first deleting the Thunderbird folders in Roaming and Local. Maximise Thunderbird, close thunderbird, reopen, it is not maximised anymore.
With Thunderbird 52.9.1 all was well. We use some code to copy xulstore.json to a new profile. This works fine, without this code this issue is also there. After closing thunderbird we look into the xulstore.json in the profile:
> "messengerWindow":{"screenX":"0","screenY":"0","width":"2560","height":"1052","sizemode":"maximized"},
But it doesn't respect this setting! You can even make an empty xulstore.json with only this line:
>{"chrome://messenger/content/messenger.xul":{"messengerWindow":{"sizemode":"maximized"}}}
And it will not maximise the window.
Comment 19•6 years ago
|
||
Of course I found the cause of my issue:
privacy.resistFingerprinting was set to true.
Perhaps the reporter has this same issue?
Reporter | ||
Comment 20•6 years ago
|
||
(In reply to jjurkus from comment #19)
> Of course I found the cause of my issue:
> privacy.resistFingerprinting was set to true.
>
> Perhaps the reporter has this same issue?
privacy.resistFingerprinting is set to false here
Comment 22•5 years ago
|
||
Stanzilla, please don't change the version# - it should stay at it's original value.
Richard/jorg, do you know a core dev who might give us insight?
Flags: needinfo?(richard.marti)
Flags: needinfo?(jorgk)
Version: 70 → 58 Branch
Comment 23•5 years ago
|
||
Jim already answered in comment #15. You meant Mozilla core, I assume.
Flags: needinfo?(jorgk)
Comment 26•5 years ago
|
||
(In reply to Stanzilla from comment #25)
Oh sorry, want me to change it back?
I already changed it back ;)
Flags: needinfo?(vseerror)
Comment 27•4 years ago
|
||
You will want to use a test profile to find the regression range using https://mozilla.github.io/mozregression/
Flags: needinfo?(staneck)
Keywords: regression,
regressionwindow-wanted
Comment 28•3 years ago
|
||
Confirming this still seems to be present in TB 91.0b4. See bug 1576738.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•