141333 - Add Bookmark -> Bookmark This Page

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Gervase Markham [:gerv]]

Currently the context menu item for adding a bookmark immediately (Bookmark This
Page) and the one in the Bookmarks menu (Add Bookmark) are inconsistent.
Pixeljockeys decided to standardise on Bookmark This Page for both - so the
Bookmarks menu item needs to change name.

Gerv

Comment 1

[mental]

I'm certainly in favor of consistency, but the context menu is broken as is...
see bug 135417.

Comment 2

[Gervase Markham [:gerv]]

We also discussed that issue; it was decided to leave it as it was for the
moment, and expose the change to a wider audience. The current behaviour is how
it worked in 4.x, after all.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Nominating as requested by trudelle in bug 141331.

Gerv

Comment 4

[Samir Gehani]

Nav triage team: nsbeta1+, adt3 rtm

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Easy fix

Do we also want to rename the 'Add to bookmarks' foo in the search sidebar
panel?	(Right click a search result)

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

->me.  reviews wanted :)

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 84983 [details] [diff] [review]
Easy fix

> Do we also want to rename the 'Add to bookmarks' foo in the search sidebar
> panel?	(Right click a search result)

Ideally, yes, but it risks kicking off more debate, and that menu has much
lower visibility.

r=gerv.

Gerv

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 84983 [details] [diff] [review]
Easy fix

jag says rs=jag

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in on the trunk.  Adding to ADT's radar.

Comment 10

[Jaime Rodriguez, Jr.]

Changing from adt1.0.0 to adt1.0.1, as we are now in a new milestone. :-)

Comment 11

[Peter Trudelle]

This should be resolved as fixed, since it is fixed on the trunk.

Comment 12

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch, pending Driver's
approval.

Comment 13

[Judson Valeski]

please checkin to the 1.0.1 branch ASAP. once there please remove the
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword.

Comment 14

[Christopher Aillon (sabbatical, not receiving bugmail)]

Landed on the branch.

Comment 15

[Ben Bucksch (:BenB)]

Counter bug 156121 filed.

Comment 16

[Paul Wyskoczka]

QA --> [e-mail]

Comment 17

[Claudius Gayle]

VERIFIED Fixed on Branch and trunk builds 20020727