135417 - File Bookmark in context menus, not Bookmark This Page.

Status: RESOLVED WORKSFORME

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[Jason Bassford]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020403
BuildID:    2002040303

It seems to me that rather than having "Bookmark This Page" in the context
menus, we should have "File Bookmark".  The latter does exactly the same thing,
with the exception of an additional mouse click, but it also adds far more
functionality.

I discovered this when I was unable to access "File Bookmark", in order to
create a tab group, except via the menu.  In the old context menu I could access
"File Bookmark".

Alternatively, a context menu item of "Bookmarks" could expand into any of the
bookmark sub-menus, including the two mentioned above.

Reproducible: Always
Steps to Reproduce:
1. Right-click.
2. See "Bookmark This Page".

Actual Results:  Only "Bookmark This Page" is available in the new context menus.

Expected Results:  There should be some method of getting to "File Bookmark" via
the new context menus - either by replacing "Bookmark This Page", or by using a
"Bookmarks" item that expands into further bookmark commands.

Comment 1

[Matthew T (active 1999-2002)]

Confirmed, 2002040303, Mac OS 9.2. Without the confirmation provided by the 
File Bookmark dialog, someone mousing up in slightly the wrong place when 
aiming for Save Page As could easily end up adding a bookmark by mistake -- 
with no obvious evidence that that's what has happened. This is more important 
in the shortcut menu than for normal menus, because people try to move through 
shortcut menus quickly and gesturally (regardless of what happens after they 
mouse up).

Comment 2

[Paul Wyskoczka]

qa --> [e-mail]

Comment 3

[Chris Lyon]

*** Bug 135843 has been marked as a duplicate of this bug. ***

Comment 4

[xyzzy]

This makes life so difficult for me that I had to rig up a quick workaround.  I
just played in the context menu, so this probably isn't the right fix.  I
changed contentAreaContextOverlay.xul in comm.jar line 115:

oncommand="gContextMenu.addBookmark();"/>                       

changed to

oncommand="BookmarksUtils.addBookmarkForBrowser(document.getElementById('content').webNavigation,
true);"/>

This reverts to the previous version's handling, and works well enough to help
get me back on track.  Hope it helps somebody else...

Comment 5

[wazow]

This is espacially annoying together with bug 133351. You have no way to
indicate the destination folder for bookmark and once you made this mistake (and
filed it with context menu) you have no way to move it (other than opening
manage bookmarks window). Thus creating a bookmark became a very time-consuming
operation.

confirming : RH 7.2, nightly build 2002041108

Comment 6

[Blake Ross]

-> marlon

Comment 7

[mental]

*** Bug 138538 has been marked as a duplicate of this bug. ***

Comment 8

[mental]

*** Bug 139208 has been marked as a duplicate of this bug. ***

Comment 9

[mental]

*** Bug 140005 has been marked as a duplicate of this bug. ***

Comment 10

[R.K.Aa.]

*** Bug 142267 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

*** Bug 143272 has been marked as a duplicate of this bug. ***

Comment 12

[mental]

*** Bug 144451 has been marked as a duplicate of this bug. ***

Comment 13

[mental]

*** Bug 144991 has been marked as a duplicate of this bug. ***

Comment 14

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 16

[Philip Chee]

Bookmark this page... menu item now opens the bookmark star panel which allows you to choose which folder to put the bookmark in.

User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 SeaMonkey/2.14a1
Build identifier: 20120814163219