In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/tools/profiler/Unified_cpp_tools_profiler1.cpp:11: /data/jenkins/workspace/firefox-clang-last/tools/profiler/lul/LulDwarf.cpp:299:61: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register] virtual bool Handle(Handler *handler, uint64 address, int register) const = 0; This isn't a big deal but we should rename the variable just to silent the warning.
Comment on attachment 8925358 [details] Bug 1414636 - Rename the 'register' variable to silent a warning https://reviewboard.mozilla.org/r/196508/#review202886 r+ but please also change the comment above it to match: 2 x (REGISTER -> REG).
Attachment #8925358 - Flags: review?(jseward) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e47ba5950c9ce450b2c5df03cc5ee02dd9815816 Bug 1414636 - Rename the 'register' variable to silent a warning r=jseward
Comment on attachment 8925358 [details] Bug 1414636 - Rename the 'register' variable to silent a warning Removing apparently-redundant review request. I don't know how that got there.
Attachment #8925358 - Flags: review?(jseward)
Attachment #8925358 - Attachment is obsolete: true
No longer blocks: clang-based-analysis
6 days ago
Type: enhancement → defect
You need to log in before you can comment on or make changes to this bug.