1416614 - Crash in mozilla::layers::HostIPCAllocator::SendPendingAsyncMessages

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Nearly all crashes on Windows from the last 2 weeks and some from Mac have WebRender enabled.
> 3 	xul.dll 	mozilla::wr::NotifyDidRender 	gfx/webrender_bindings/RenderThread.cpp:201
They seem to affect WebRender in some way.

Windows example: bp-aec114af-d64c-473e-affb-ae2b20171112 (build 2017-11-09_220104)
> 0 	xul.dll 	mozilla::layers::HostIPCAllocator::SendPendingAsyncMessages() 	gfx/layers/ipc/ISurfaceAllocator.cpp:41
> 1 	xul.dll 	mozilla::layers::ImageBridgeParent::NotifyImageComposites(nsTArray<mozilla::layers::ImageCompositeNotificationInfo>&) 	gfx/layers/ipc/ImageBridgeParent.cpp:392
> 2 	xul.dll 	mozilla::layers::CompositorBridgeParent::NotifyDidCompositeToPipeline(mozilla::wr::PipelineId const&, mozilla::wr::Epoch const&, mozilla::TimeStamp&, mozilla::TimeStamp&) 	gfx/layers/ipc/CompositorBridgeParent.cpp:1983
> 3 	xul.dll 	mozilla::wr::NotifyDidRender 	gfx/webrender_bindings/RenderThread.cpp:201
> 4 	xul.dll 	RunnableFunction<void (*)(mozilla::layers::CompositorBridgeParentBase*, mozilla::wr::WrRenderedEpochs*, mozilla::TimeStamp, mozilla::TimeStamp), mozilla::Tuple<mozilla::layers::CompositorBridgeParentBase*, mozilla::wr::WrRenderedEpochs*, mozilla::TimeStamp, mozilla::TimeStamp> >::Run() 	ipc/chromium/src/base/task.h:350
> 5 	xul.dll 	MessageLoop::DoWork() 	ipc/chromium/src/base/message_loop.cc:535
> 6 	xul.dll 	base::MessagePumpForUI::DoRunLoop() 	ipc/chromium/src/base/message_pump_win.cc:210
> 7 	xul.dll 	base::MessagePumpWin::Run(base::MessagePump::Delegate*) 	ipc/chromium/src/base/message_pump_win.h:80
> 8 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:319
> 9 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc:299
> 10 	xul.dll 	base::Thread::ThreadMain() 	ipc/chromium/src/base/thread.cc:181
> 11 	xul.dll 	`anonymous namespace'::ThreadFunc 	ipc/chromium/src/base/platform_thread_win.cc:28
> 12 	kernel32.dll 	BaseThreadInitThunk 	
> 13 	ntdll.dll 	RtlUserThreadStart

Two weeks old Mac example: bp-85130e50-9f46-4763-ae65-1157f0171031 (build 2017-10-30_103605)
> 3 	XUL 	mozilla::wr::NotifyDidRender(mozilla::layers::CompositorBridgeParentBase*, mozilla::wr::WrRenderedEpochs*, mozilla::TimeStamp, mozilla::TimeStamp) 	gfx/webrender_bindings/RenderThread.cpp:200

Comment 1

[Sotaro Ikeda [:sotaro]]

From the crash reports, the crash seemed to happen with/without WebRender.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add checks to ImageBridgeParent::NotifyImageComposites

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=523b16fa82a540c99c4c4822f7c11a25f9f814a2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db2a8ddbdb48
Add checks to ImageBridgeParent::NotifyImageComposites r=nical

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/db2a8ddbdb48

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this.

Comment 7

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8927698 [details] [diff] [review]
patch - Add checks to ImageBridgeParent::NotifyImageComposites

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1143575
[User impact if declined]: Could cause crash in some cases with video playback.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It just added simple checks.
[String changes made/needed]: No

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8927698 [details] [diff] [review]
patch - Add checks to ImageBridgeParent::NotifyImageComposites

Fix a crash. Beta58+.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3221f428493e