1417943 - Search box gets focus after entering input in location bar for about:home

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[mubbuoss]

this is merely a distracting graphical glitch, but the activity stream in-page search box gets focused (highlighted with bright blue border) as soon as you hit enter for an input in the location bar (this happens only with the initial tab at browser startup).

Comment 1

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Last good revision: 8ce27eeef7662c04deed1328ff25937e530aaf79
First bad revision: e3221268f8fc67bd461c2e04ed486e264c070abf
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8ce27eeef7662c04deed1328ff25937e530aaf79&tochange=e3221268f8fc67bd461c2e04ed486e264c070abf

This seems to have been caused by bug 1403215.

It's also reproducible when you click the Search arrow without having a keyword in the search bar.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/bb4726eb42778e9bdc060ba0fce0b3cd6d370d25
fix(search): Close Bug 1417943 - in-page search box gets focus after entering input in location bar (only on initial tab at browser startup) (#3881)

Also fix Bug 1400585 - With activity-stream.aboutHome.autoFocus set, initil focus is in the address bar then moves to content search
Also fix Bug 1421417 - Focus moves to about:home search box when turning on the search preference

Comment 3

[Ed Lee :Mardak]

This has not landed in 59 yet

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/ea7f2137961f

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180126035135

I have verified that this issue is no longer reproducible on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12 with the latest Nightly build (60.0a1) installed. Now the "Activity Stream" search bar is not focused when the "Enter" key is pressed for an input in the location bar.

Comment 6

[Cornel Ionce [:noni] [Hubs QA]]

Updating the bug status and the tracking flags to reflect the current situation, based on the above comment.

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 59 beta 5 under Ubuntu 14.04 64-bit, Mac OS X 10.13 and Win 10 64 bit.

Comment 8

[mc456man]

What this did was create a new bug that is frustrating to actual users
https://bugzilla.mozilla.org/show_bug.cgi?id=1446828