1418081 - Update builders to rust 1.23.0

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Rust 1.23.0 is scheduled for stable release 2018 January 4. Update builders when that release is available.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1418081 - Update builders to rust 1.23.0.

New upstream release.

- Avoiding argument copies improves memory footprint.
- RwLock<T> no longer requires T to be Send.
- AsciiExt trait methods are now directly available
  on str, [u8], u8, and char types without a `use`
  statement.

Review commit: https://reviewboard.mozilla.org/r/211056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211056/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8940784 [details]
Bug 1418081 - Update builders to rust 1.23.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211056/diff/1-2/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8940784 [details]
Bug 1418081 - Update builders to rust 1.23.0.

https://reviewboard.mozilla.org/r/211056/#review216944

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa0e2d59775c
Update builders to rust 1.23.0. r=ted

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for valgrind-test failure.

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155064767&repo=autoland&lineNumber=33862
Rev: https://hg.mozilla.org/integration/autoland/rev/7a93234cb5eb9172321aea3cc0f0725d45d7ee04

Comment 6

[Ralph Giles (:rillian)]

These look like bug 1418083.

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8940784 [details]
Bug 1418081 - Update builders to rust 1.23.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211056/diff/2-3/

Comment 8

[Ralph Giles (:rillian)]

Given there are still outstanding bugs blocking this from landing, and that we're now one week away from uplift to Firefox 59 beta, I plan to leave Firefox 59 building with Rust 1.22.0. We'll update as soon as possible once m-c becomes Firefox 60 Nightly.

Comment 9

[Mike Hommey [:glandium]]

Did you check talos? The landing of bug 1401647, which effectively made 32-bits builds use 1.22 instead of 1.23 beta showed performance improvements, suggesting performance regressions from rust 1.23 codegen.

Comment 10

[Ralph Giles (:rillian)]

I haven't done a talos run, no.

Comment 11

[Ralph Giles (:rillian)]

Comment on attachment 8940784 [details]
Bug 1418081 - Update builders to rust 1.23.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211056/diff/3-4/

Comment 12

[Ralph Giles (:rillian)]

Try push, with talos this time. https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc02c849cb0a453319663ccac8b0fd298f2a8f40

Looks like another valgrind issue has snuck in.

Comment 13

[Ralph Giles (:rillian)]

Valgrind issue isn't showing up this week, so trying again.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28ee1007dae0
Update builders to rust 1.23.0. r=ted

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/28ee1007dae0

Comment 16

[Ionuț Goldan [:igoldan]]

This improved some Stylo tests:

== Change summary for alert #11278 (as of Wed, 24 Jan 2018 23:42:28 GMT) ==

Improvements:

 11%  Stylo Servo_DeclarationBlock_SetPropertyById_Bench osx-10-10 opt      602,051.67 -> 537,327.00
 11%  Stylo Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench osx-10-10 opt 604,456.83 -> 539,541.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11278