1419179 - Migrate statusbar and statusbarpanel to TB

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Brian Grinstead [:bgrins]]

In Bug 1419170 I'm planning to remove statusbar and statusbarpanel bindings from mozilla-central.  They are used in a variety of places in comm-central: https://dxr.mozilla.org/comm-central/search?q=%3Cstatusbar&redirect=false, so they should be moved somewhere to remain usable.

Comment 1

[Brian Grinstead [:bgrins]]

There's also a test: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/tests/chrome/test_statusbar.xul

Comment 2

[Stefan [:stefanh]]

Frank, Ian

Me and Richard had a chat about migrating bindings to a place in c-c where both TB and SM could use them. We could for example have a "bindings" directory in the root of c-c and move bindings needed by SM or TB to there. What do you think?

Comment 3

[Frank-Rainer Grahl (:frg)]

I am for it becuase I don't think everything should go into mailnews if not directly related. But I would add another high level directory and put bindings in it. Over time something else might end there too. 

I already thought about it and asked in Bug 1414398 Commment 25

Comment 4

[Jorg K (CEST = GMT+2)]

So Richard and Stefan, I assume that this will be under control, right?

Comment 5

[Richard Marti (:Paenglab)]

I think, yes.

Comment 6

[Stefan [:stefanh]]

Richard has it covered for TB. I made a suite patch in bug 1418094, since I was unsure of how much time we had for creating a shared dir. We both agree on a shared dir, though. So we'll move the bindings to a shared dir at a later stage.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: statusbar-TB.patch

The binding file (generalBindings.xml) is in /common/bindings. Like this TB and SM can access it easily and only one binding file is needed for both programs.

Aceman and the others, is the naming okay or do you want something different?

Aceman, you can test this with applying the patch from bug 1419170.

Comment 8

[:aceman]

Comment on attachment 8931496 [details] [diff] [review]
statusbar-TB.patch

Review of attachment 8931496 [details] [diff] [review]:
-----------------------------------------------------------------

I can't test this for the next 2 days, but it looks fine to me.

::: mail/themes/linux/mail/messenger.css
@@ +583,5 @@
>  menulist[editable="true"] > .menulist-dropmarker {
>    min-width: 2em;
>  }
>  
> +/* statusbar */

Maybe "Status bar" to have the same style as the "Status panel" below?

Comment 9

[Richard Marti (:Paenglab)]

Attachment: statusbar-TB.patch

Fixed the titles in the CSS files.

Aceman, no hurry, the m-c patch hasn't landed yet.

Comment 10

[Stefan [:stefanh]]

(In reply to Richard Marti (:Paenglab) from comment #7) 
> Aceman and the others, is the naming okay or do you want something different?

Thanks for doing this :-) No objections (my suggestion would be shared/bindings, but it really doesn't matter).

Comment 11

[:aceman]

Comment on attachment 8931633 [details] [diff] [review]
statusbar-TB.patch

Review of attachment 8931633 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, applying bug 1419170 breaks the status bar a bit and this patch fixes it. Thanks.

Who will make the Seamonkey version of this?

Comment 12

[Richard Marti (:Paenglab)]

Stefan has signaled to do this.

Comment 13

[Stefan [:stefanh]]

Yeah, I'll do it for SeaMonkey in bug 1418094.

Comment 14

[Richard Marti (:Paenglab)]

Okay, then I rename the bug to TB only.

Comment 15

[Stefan [:stefanh]]

Comment on attachment 8931633 [details] [diff] [review]
statusbar-TB.patch

It looks like you forgot this: https://dxr.mozilla.org/mozilla-central/rev/b2200418de0bf215a84d84317d247363536369dd/toolkit/content/xul.css#255

Comment 16

[Richard Marti (:Paenglab)]

I haven't added it because at least on Windows, dragging the window with the status bar is not usual. It also makes the offline button almost not accessible (this I fixed through changing it to a toolbar-button). But also by right clicking on the status bar, showing the window menu is strange.

Comment 17

[Richard Marti (:Paenglab)]

Bug 1419170 should land on the next merge. Then this bug can land then and seamlessly fix it.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c5cab791999a
Migrate statusbar and statusbarpanel to comm-central. r=aceman