1418094 - Migrate statusbar* bindings from m-c to suite/common/bindings/general.xml

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Comment 1

[Stefan [:stefanh]]

Attachment: MIgrate bindings

I think it makes more sense to have the style rules in communicator.css. Not sure why Kairo put the rules in toolbar.css, maybe because he originally added the binding in toolbar.xml (bug 579731).

Comment 3

[Stefan [:stefanh]]

Comment on attachment 8929192 [details] [diff] [review]
MIgrate bindings

I've noticed that statusbar and statusbarpanel bindings are going away in bug 1419170 (and also the css in global.css), so I'll include those bindings here as well.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Stefan [:stefanh] from comment #3)
> I've noticed that statusbar and statusbarpanel bindings are going away in
> bug 1419170 (and also the css in global.css), so I'll include those bindings
> here as well.

FYI I've pushed up a proposed patch to Bug 1419170 and added some more detail in https://bugzilla.mozilla.org/show_bug.cgi?id=1419170#c6

Comment 5

[Stefan [:stefanh]]

(In reply to Brian Grinstead [:bgrins] from comment #4) 
> FYI I've pushed up a proposed patch to Bug 1419170 and added some more
> detail in https://bugzilla.mozilla.org/show_bug.cgi?id=1419170#c6

Thanks Brian.

Comment 6

[Stefan [:stefanh]]

Attachment: Migrate bindings

Here's a patch that adds all the statusbar* bindings (used by suite) to general.xml. It also moves statusbar* style rules from modern's global.css to communicator.css.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8930677 [details] [diff] [review]
Migrate bindings

Go for it. Thanks!

Comment 8

[Stefan [:stefanh]]

Comment on attachment 8930677 [details] [diff] [review]
Migrate bindings

Turns out that Richard have a patch in bug 1419179 where he moves statusbar and statusbarpanel bindings to a shared dir in c-c, so I'll wait with this until the move is settled.

Comment 9

[Stefan [:stefanh]]

Richard, will Thunderbird have any need for the statusbarpanel-iconic and statusbarpanel-iconic-text bindings? If not, I'll put them in /suite/common/bindings/general.xml - there's already a binding there that extends statusbarpanel-iconic-text.

Comment 10

[Richard Marti (:Paenglab)]

TB removed the need of the statusbarpanel-iconic and statusbarpanel-iconic-text bindings. You can put them in your general.xml.

Comment 11

[Stefan [:stefanh]]

Attachment: Migrate statusbarpanel-iconic, statusbarpanel-iconic-text bindings from m-c to suite/common/bindings/general.xml

This is part1. This patch is similar to attachment #8929192 [details] [diff] [review] - the only difference is that this one use the style rules for statusbarpanel-iconic and statusbarpanel-iconic-text in modern's global.css (moves them to communicator.css).

This patch should be testable without patches from bug 1419179 and bug 1419170 as long as the patch in bug 1419170 doesn't land (the added bindings extends the statusbarpanel binding which is removed in bug 1419170).

I will post part2 soon (which will require the patch in bug 1419179.

Comment 12

[Stefan [:stefanh]]

Attachment: Use the c-c statusbar/statusbarpanel bindings and migrate css

This is part2:

Applies on top of attachment #8931952 [details] [diff] [review] and requires Richards patch in bug 1419179 (attachment #8931633 [details] [diff] [review]). For proper testing, apply Brians patch in bug 1419170 (attachment #8930611 [details]) or wait until it has landed.

Comment 13

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8931952 [details] [diff] [review]
Migrate statusbarpanel-iconic, statusbarpanel-iconic-text bindings from m-c to suite/common/bindings/general.xml

> +++ b/suite/themes/classic/communicator/communicator.css

> +.statusbarpanel-iconic,
> +.statusbarpanel-iconic-text {
> +  padding: 0 1px;
> +

Missing closing bracket but seems to work well otherwise.

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8931960 [details] [diff] [review]
Use the c-c statusbar/statusbarpanel bindings and migrate css

Works but needs to be unbitrotted and refreshed after fixing the closing bracket.

Comment 15

[Stefan [:stefanh]]

(In reply to Frank-Rainer Grahl (:frg) from comment #13)
> Comment on attachment 8931952 [details] [diff] [review]
> Migrate statusbarpanel-iconic, statusbarpanel-iconic-text bindings from m-c
> to suite/common/bindings/general.xml
> 
> > +++ b/suite/themes/classic/communicator/communicator.css
> 
> > +.statusbarpanel-iconic,
> > +.statusbarpanel-iconic-text {
> > +  padding: 0 1px;
> > +
> 
> Missing closing bracket but seems to work well otherwise.

Whoops, I'll fix that once Ian have looked at the patches.

Comment 16

[Stefan [:stefanh]]

Attachment: Part 1: Migrate statusbarpanel-iconic, statusbarpanel-iconic-text bindings from m-c to suite/common/bindings/general.xml

Part 1 updated (comment #13)

Comment 17

[Stefan [:stefanh]]

Attachment: Part 2: Use the c-c statusbar/statusbarpanel bindings and migrate css

Part 2 refreshed. I also fixed the bracket below (modern/communicator/communicator.css)

+.statusbar-resizerpanel 
+{

Comment 19

[Ian Neal]

Comment on attachment 8936015 [details] [diff] [review]
Part 1: Migrate statusbarpanel-iconic, statusbarpanel-iconic-text bindings from m-c to suite/common/bindings/general.xml

>+++ b/suite/themes/modern/communicator/communicator.css
>+/* ::::: status bar panels ::::: */
>+
>+.statusbarpanel-iconic {
>+  padding: 0px;
>+}
>+
>+.statusbarpanel-text {
>+  margin: 0px !important;
>+}

Nit: needs an extra blank line here.

>+.statusbarpanel-backgroundbox {
>+  -moz-box-align: stretch;
>+  padding: 0px;
>+}
>+
>+.statusbarpanel-backgroundbox > .statusbarpanel-contentbox {
>+  padding: 0px 4px;
>+  -moz-box-align: center;
>+}

r=me with that fixed.

Comment 20

[Ian Neal]

Comment on attachment 8936016 [details] [diff] [review]
Part 2: Use the c-c statusbar/statusbarpanel bindings and migrate css

r=me

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/608854301907
Migrate statusbarpanel-iconic, statusbarpanel-iconic-text bindings from m-c to suite/common/bindings/general.xml. r=IanN.
https://hg.mozilla.org/comm-central/rev/638b68e22577
Use the c-c statusbar/statusbarpanel bindings and migrate css. r=IanN.