Closed Bug 1419460 Opened 6 years ago Closed 6 years ago

[gnome-shell, Ubuntu 17.10] Titlebar is shown despite settings to draw in the titlebar

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1419460 - search XDG_CURRENT_DESKTOP for desktop environment type substring,
59 bytes, text/x-review-board-request
jhorak
: review+
Details 
Follow up from Bug 1417933 comment 11. Gnome-shell should support GDK_DECOR_BORDER, we need to investigate why it's ignored on Ubuntu 17.10.
It's because Ubuntu sets XDG_CURRENT_DESKTOP to "ubuntu:GNOME" instead of "GNOME" so the titlebar style is not detected properly and the titlebar is disabled.
Bug 1419456 needs to land before we fix this one.
Depends on: 1419456
See Also: → 1418823
See Also: 1418823 → 
Comment on attachment 8931346 [details]
Bug 1419460 - search XDG_CURRENT_DESKTOP for desktop environment type substring,

https://reviewboard.mozilla.org/r/202482/#review208898

::: commit-message-b6bed:1
(Diff revision 1)
> +Bug 1419460 - search XDG_CURRENT_DESKTOP for DE type substring, r?jhorak

Please add a brief description why this is needed, and to the source code why the substring is checked.
Attachment #8931346 - Flags: review?(jhorak)
Comment on attachment 8931346 [details]
Bug 1419460 - search XDG_CURRENT_DESKTOP for desktop environment type substring,

https://reviewboard.mozilla.org/r/202482/#review209720
Attachment #8931346 - Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/f6bd72fc9215
search XDG_CURRENT_DESKTOP for desktop environment type substring, r=jhorak
https://hg.mozilla.org/mozilla-central/rev/f6bd72fc9215
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.