1419461 - Crash in nsWindow::NativePtr<T>::Detach

Status: RESOLVED WORKSFORME

(Core Graveyard :: Widget: Android, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-957e6b03-f785-481e-8d88-ed01e0171121.
=============================================================

Seen while reviewing Android crash stats: http://bit.ly/2Bb3Xtp. Crashes occur on API 24 only, using Samsung hardware. This crash was present in 56 as well, but more visible in 57. Currently #32 top browser crash.

Comments:

*Was adding Firefox to splitscreen and it crashed immediately, will retest now 
*crashed in pop up mode 

Top 10 frames of crashing thread:

0 libxul.so nsWindow::NativePtr<nsWindow::LayerViewSupport>::Detach widget/android/jni/Refs.h:77
1 libxul.so nsWindow::GeckoViewSupport::Reattach widget/android/nsWindow.cpp:1368
2 libxul.so mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoView::Window, false, true, const mozilla::jni::Ref<mozilla::java::GeckoView, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>::operator widget/android/jni/Natives.h:428
3 libxul.so nsWindow::WindowEvent<mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoView::Window, false, true, const mozilla::jni::Ref<mozilla::java::GeckoView, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>, false, const mozilla::jni::Ref<mozilla::java::GeckoView::Window, _jobject*>&, nsWindow::GeckoViewSupport>::Run widget/android/nsWindow.cpp:161
4 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1039
5 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:521
6 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:97
7 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:319
8 libxul.so nsBaseAppShell::Run widget/nsBaseAppShell.cpp:158
9 libxul.so nsAppStartup::Run toolkit/components/startup/nsAppStartup.cpp:288

=============================================================

Comment 1

[Marcia Knous [:marcia]]

Ioana - Do think someone on you end can try to reproduce this issue on a Samsung device?

Comment 2

[Marcia Knous [:marcia]]

ni on No-Jun - can we get someone to try to reproduce this on a Samsung device?

Comment 3

[Ioana Chiorean]

Hey Marcia, 
Sorry to have missed this. At this point we are out of office and I only have a Pixel with me. I cna try to find someone with a phone but i am not sure of the success. 

If No Jun won't find anyone, this will be on our table Monday, first hour. ( We are OOO Nov 30, Dec 1st as they are National holidays). 
Will leave the NI on me.

Comment 4

[No-Jun Park [:njpark]]

I looked around but I don't have access to Samsung with API 24 - it looks like we have to wait until Monday for this.

Comment 5

[Ioana Chiorean]

Tested with S6, S6 Edge, S7 and Samsung Galaxy tab with API 24/Android 7.0. 
- Tried to browser in split screen, play video and other action - all ok.
- Tested with pop ups - loaded multi pop us, new tabs (popuptests) - all ok 

i was not able to reproduce the crash at all.

Comment 6

[Marcia Knous [:marcia]]

Some of the comments mention "tried to use Pop Up view on Galaxy S8 " - so I assume that is a pref that has to be enabled in Settings? Do you have a Galaxy S8? Thanks.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Too soon to tell if 58/59 are affected, but it's also too late to fix this for 57.

Comment 8

[Ioana Chiorean]

(In reply to Marcia Knous [:marcia - use ni] from comment #6)
> Some of the comments mention "tried to use Pop Up view on Galaxy S8 " - so I
> assume that is a pref that has to be enabled in Settings? Do you have a
> Galaxy S8? Thanks.

Indeed that seems to be a new feature and we do have a S8 (but not with me). Bogdan can you pls have a look at this ( as the phone is in your custody/or anyone from BM) 
Feature details: https://www.androidcentral.com/how-use-multi-window-samsung-galaxy-s8

Comment 9

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Samsung Galaxy S8 (Android 7.0);
 - Samsung Galaxy Tab S3 (Android 7.0).

Hello,

 I was not able to reproduce any crash when using split screen with FF in any of the scenarios listed in Comment 5, tested with multiple tabs diverse video content and pages and everything worked fine.

 I was able however to constantly reproduce a crash when using the pop-up view option(window in window).  Crash report here: https://crash-stats.mozilla.com/report/index/482593bf-c215-40e0-8b77-2f8220180108

STR:
 1. Open FF;
 2. Tap on the recent apps button;
 3. Long tap and drag the FF window in the pop-up view area;
 4. Open several window or browse to some pages.

Expected results:
 Firefox works normally without any crashes.

Actual results:
 Firefox crashes instantly when using it in pop-up view or after navigating to some pages.

Notes:
 Only FF Beta and Release crashed in both of the devices. Nightly worked without crashing.
 Video: https://goo.gl/E9csiF

Comment 10

[Marcia Knous [:marcia]]

No recent crashes. Resolving as WFM.