Upgrade Firefox 59 to NSS 3.35

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: franziskus, Assigned: franziskus)

Tracking

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Tracking NSS 3.35 for Firefox 59.

Comment 2

2 years ago
Pushed by franziskuskiefer@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40f90a8fd17d
land NSS ff7594d3dc94 UPGRADE_NSS_RELEASE, r=me
Backe out for xpcshell failures on test_pkcs11_module.js

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40f90a8fd17ddc13f6c7100541c74d4df51917f5&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable

https://treeherder.mozilla.org/logviewer.html#?job_id=147069050&repo=mozilla-inbound&lineNumber=10866
10:58:33     INFO -  TEST-START | security/manager/ssl/tests/unit/test_pkcs11_module.js
10:58:33  WARNING -  TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_pkcs11_module.js | xpcshell return code: 0
10:58:33     INFO -  TEST-INFO took 342ms
Flags: needinfo?(franziskuskiefer)

Comment 4

2 years ago
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c669cc6ea52
Backed out 1 changesets for xpcshell failures on test_pkcs11_module.js UPGRADE_NSS_RELEASE r=backout on a CLOSED TREE
Sorry about that. We changed something in NSS and have to adapt Firefox tests accordingly.
Flags: needinfo?(franziskuskiefer)
Comment on attachment 8931594 [details]
Bug 1420060 - FIPS can no longer be toggled in Firefox with the builtin NSS, r=ttaubert

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D282#6845
Attachment #8931594 - Flags: review+

Comment 8

2 years ago
Pushed by franziskuskiefer@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c40802096cd
land NSS ceb8b9290b35 UPGRADE_NSS_RELEASE, r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/45e4387bc585
FIPS can no longer be toggled in Firefox with the builtin NSS, r=ttaubert

Updated

2 years ago
See Also: → 1420407
Franziskus, is there a reason that mozilla-central still uses an NSS snapshot from Nov 24 ?

It would be helpful to have a newer snapshot for bug 1426102.
Flags: needinfo?(franziskuskiefer)

Comment 11

2 years ago
Pushed by franziskuskiefer@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba3a2c41b4b9
land NSS 04fc9a90997b UPGRADE_NSS_RELEASE, r=me
Flags: needinfo?(franziskuskiefer)

Updated

2 years ago
Duplicate of this bug: 1405268

Comment 15

Last year
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ce1e0ca10e1
trivial bustage fix, export new NSS APIs in Firefox' specific API export list
Added symbols should be enclosed with #ifdef XP_WIN and #endif.

Comment 17

Last year
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7604bcd50b63
additional bustage fix as suggested by Masatoshi Kimura, r=kaie, CLOSED TREE
(In reply to Masatoshi Kimura [:emk] from comment #16)
> Added symbols should be enclosed with #ifdef XP_WIN and #endif.

thanks a lot, this was very helpful. Checked in.
See bug 1428538 comment #11. I think this backout was false positive.

Comment 21

Last year
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92dcb99abd05
NSS_3_35_BETA1, r=franziskus
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddfff454c810
export new NSS APIs in Firefox' specific API export list, r=franziskus
https://hg.mozilla.org/integration/mozilla-inbound/rev/35dcf8417877
restrict export of symbols to Windows, suggested by Masatoshi Kimura, r=kaie
Relanded as Franziskus asked me to, based on the results of the try run from bug 1428538 comment 12.
Keywords: leave-open

Comment 24

Last year
Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67254794a2e0
uplift NSS_3_35_RTM, no code change, only version number. Require version 3.35 for building. r=me

Comment 25

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/67254794a2e0
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.