1420060 - Upgrade Firefox 59 to NSS 3.35

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Franziskus Kiefer [:franziskus]]

Tracking NSS 3.35 for Firefox 59.

Comment 1

[Franziskus Kiefer [:franziskus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69b01777bfd8d43f4c46fb07638f58dd5b1a496c

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40f90a8fd17d
land NSS ff7594d3dc94 UPGRADE_NSS_RELEASE, r=me

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backe out for xpcshell failures on test_pkcs11_module.js

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40f90a8fd17ddc13f6c7100541c74d4df51917f5&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable

https://treeherder.mozilla.org/logviewer.html#?job_id=147069050&repo=mozilla-inbound&lineNumber=10866
10:58:33     INFO -  TEST-START | security/manager/ssl/tests/unit/test_pkcs11_module.js
10:58:33  WARNING -  TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_pkcs11_module.js | xpcshell return code: 0
10:58:33     INFO -  TEST-INFO took 342ms

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c669cc6ea52
Backed out 1 changesets for xpcshell failures on test_pkcs11_module.js UPGRADE_NSS_RELEASE r=backout on a CLOSED TREE

Comment 5

[Franziskus Kiefer [:franziskus]]

Sorry about that. We changed something in NSS and have to adapt Firefox tests accordingly.

Comment 6

[Phabricator Automation]

Comment on attachment 8931594 [details]
Bug 1420060 - FIPS can no longer be toggled in Firefox with the builtin NSS, r=ttaubert

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D282#6845

Comment 7

[Franziskus Kiefer [:franziskus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5c62c9151a8153f117bcb2e88f66330b0136580

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c40802096cd
land NSS ceb8b9290b35 UPGRADE_NSS_RELEASE, r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/45e4387bc585
FIPS can no longer be toggled in Firefox with the builtin NSS, r=ttaubert

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0c40802096cd
https://hg.mozilla.org/mozilla-central/rev/45e4387bc585

Comment 10

[Kai Engert (:KaiE:)]

Franziskus, is there a reason that mozilla-central still uses an NSS snapshot from Nov 24 ?

It would be helpful to have a newer snapshot for bug 1426102.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba3a2c41b4b9
land NSS 04fc9a90997b UPGRADE_NSS_RELEASE, r=me

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ba3a2c41b4b9

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb3c27bdee46
NSS_3_35_BETA1, r=franziskus

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ce1e0ca10e1
trivial bustage fix, export new NSS APIs in Firefox' specific API export list

Comment 16

[Masatoshi Kimura [:emk]]

Added symbols should be enclosed with #ifdef XP_WIN and #endif.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7604bcd50b63
additional bustage fix as suggested by Masatoshi Kimura, r=kaie, CLOSED TREE

Comment 18

[Kai Engert (:KaiE:)]

(In reply to Masatoshi Kimura [:emk] from comment #16)
> Added symbols should be enclosed with #ifdef XP_WIN and #endif.

thanks a lot, this was very helpful. Checked in.

Comment 19

[Andreea Pavel [:apavel]]

Backed out for mochitest mass failures

Push with failures:  https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7604bcd50b63cc8f3e867d8844d7bab871dc0af3

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=155649398&repo=mozilla-inbound&lineNumber=3301

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/6705010893cd6d0a72f6adbcb81a92f052a041c2

Comment 20

[Masatoshi Kimura [:emk]]

See bug 1428538 comment #11. I think this backout was false positive.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92dcb99abd05
NSS_3_35_BETA1, r=franziskus
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddfff454c810
export new NSS APIs in Firefox' specific API export list, r=franziskus
https://hg.mozilla.org/integration/mozilla-inbound/rev/35dcf8417877
restrict export of symbols to Windows, suggested by Masatoshi Kimura, r=kaie

Comment 22

[Kai Engert (:KaiE:)]

Relanded as Franziskus asked me to, based on the results of the try run from bug 1428538 comment 12.

Comment 23

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/92dcb99abd05
https://hg.mozilla.org/mozilla-central/rev/ddfff454c810
https://hg.mozilla.org/mozilla-central/rev/35dcf8417877

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67254794a2e0
uplift NSS_3_35_RTM, no code change, only version number. Require version 3.35 for building. r=me

Comment 25

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/67254794a2e0