Open Bug 1420085 Opened 3 years ago Updated 3 years ago

Offer to add search module uses website favicon instead the module icon


(Firefox :: Search, enhancement, P3)





(Reporter: mstanke, Unassigned)



(Whiteboard: [fxsearch])

1. Find a web with different favicon and search module icon.
2. Try to add the module via search bar.
3. The "Add ${module_name}" prompt in the search bar drop-down uses the website favicon instead of the module icon.

I am worried this can mistaken people to think the engine has not been added, as they won't find the icon from the "Add ${}" prompt in the list later. This is currently reproducible on AMO (until fix for is deployed), but affects any website that has different icon defined in the search module than what it uses as favicon. I can create a test case if you want.
This is a good idea, if we're not doing this already.
Priority: -- → P3
Whiteboard: [fxsearch]
Yes, we're just using browser.mIconURL as the engine icon URL:

I guess it would require an extra request to get the engine icon URL because it's only in the engine XML I think, and not on the <link>?  Not sure off hand.

I was hoping we could do this along with bug 1221539, i.e., because the search bar is simply using the wrong URL, but it really is independent.
See Also: → 367882
You need to log in before you can comment on or make changes to this bug.