1420085 - Offer to add search module uses website favicon instead the module icon

Status: RESOLVED DUPLICATE of bug 1457069

(Firefox :: Search, enhancement, P3)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

STR:
1. Find a web with different favicon and search module icon.
2. Try to add the module via search bar. https://support.mozilla.org/en-US/kb/add-or-remove-search-engine-firefox#w_add-a-search-engine
3. The "Add ${module_name}" prompt in the search bar drop-down uses the website favicon instead of the module icon.

I am worried this can mistaken people to think the engine has not been added, as they won't find the icon from the "Add ${}" prompt in the list later. This is currently reproducible on AMO (until fix for https://github.com/mozilla/addons-server/issues/6995 is deployed), but affects any website that has different icon defined in the search module than what it uses as favicon. I can create a test case if you want.

Comment 1

[Drew Willcoxon :adw]

This is a good idea, if we're not doing this already.

Comment 2

[Drew Willcoxon :adw]

Yes, we're just using browser.mIconURL as the engine icon URL: https://dxr.mozilla.org/mozilla-central/rev/4fe6f6560083f8c8257282bef1d4e0ced9d1b975/browser/base/content/browser.js#3659

I guess it would require an extra request to get the engine icon URL because it's only in the engine XML I think, and not on the <link>?  Not sure off hand.

I was hoping we could do this along with bug 1221539, i.e., because the search bar is simply using the wrong URL, but it really is independent.

Comment 3

[Mark Banner (:standard8)]

Duping forward to bug 1457069, since if we do anything I think it would be there.