1457069 - Title and favicon of OpenSearch engines offered by pages do not necessarily match title and favicon they're installed with (add search engine re-appears)

Status: NEW

(Firefox :: Search, defect, P3)

Description

[David Olah]

[Environment:]
Windows 8.1, Windows 10, Mac OSX 10.13.2, Ubuntu 16.04
Nightly 61.0a1 2018-04-26

[Steps:]
1. Open Firefox Nightly and go to https://yahoo.com
2. Open the "Page actions" from the Address bar and click on "Add search engine"
3. Now that yahoo was added to the search engines, open the "Page actions" again 

[Expected Result:]
Yahoo doesn't appear in the "Page actions" after being added

[Actual Result:]
Yahoo appears in the "Page actions" and when being clicked to add again, an Install Error popup with message: <Nightly could not install the search plugin from “https://ro.search.yahoo.com/opensearch.xml” because an engine with the same name already exists.> appears

Comment 1

[David Olah]

This bug was created based on Comment 127 from Bug 1221539.

Comment 2

[:Gijs (he/him)]

Pulling in this comment on how to approach this:

(In reply to Drew Willcoxon :adw from bug 1221539 comment #134)
> Yes, could you please file a bug, David?  The only way to fix it afaict
> would be to prefetch opensearch xml.  (Which would also let us fix a similar
> bug were the favicons don't match.)

I guess this will be triaged by the folks working on the urlbar, so clearing my needinfo right now. Given it's not a regression I don't think we need to rush to fix it.

Comment 3

[Drew Willcoxon :adw]

This affects the search bar, too.  The problem is described succinctly here: https://bugzilla.mozilla.org/show_bug.cgi?id=1222107#c5

(In reply to Florian Quèze [:florian] from bug 1222107 comment #5)
> The problem here is that the name of the engine offered in the HTML page
> (<link rel="search" type="application/opensearchdescription+xml"
> href="https://fr.search.yahoo.com/opensearch.xml" title="Yahoo Search" />)
> doesn't match the actual name of the engine once we download it: 
> <ShortName>Yahoo</ShortName>

Comment 9

[Mark Banner (:standard8)]

The fundamental problem here is that the website is providing two different values - one in the web page, and one in the xml definition. Ideally the website would fix it. However we see it often enough that we should try to improve how we handle it.

We don't want to request the xml again, as that increases the amounts of loads and processing that we are doing.

Discussing this today, we had a theory that we could potentially check against the load URL as well as the name. We would need to store the load URI of the engine (currently we only store an obfuscated version that's used for the loadURL telemetry), and then when we check the name, we also check against the install URL as well. Obviously this can't fix it for engines that the user has already installed, however we can fix it for future additions.

Comment 10

[Dale Harvey (:daleharvey)]

Attachment: Bug 1457069 - Store opensearch url to prevent duplicate installs.