367882 - use current page's favicon rather than domain's favicon.ico for "Add engine" menu item

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P3)

Description

[Pavel Franc - Mozilla.cz]

While showing the 'Add "{ENGINE-TITLE}"' item in the search popup menu, there is sometime added the site favicon. This is only in the case when the favicon exists at /favicon.ico url. 

See browser.js:
          iconURL = browser.currentURI.prePath + "/favicon.ico"

However this is not the correct url for many cases. We should use the same url as we use in the addressbar

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Hrm, I've thought of this before, and I'm almost certain there was a reason I decided we couldn't do that, but now I can't recall what it is...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(and by 'do that' I mean 'use gProxyFavIcon.getAttribute("src")')

Comment 3

[Simon Males]

I think this may be another bug, but once an OpenSearch engine is installed it should use the URI from the <Image> element as per the specification.

http://www.opensearch.org/Specifications/OpenSearch/1.1#The_.22Image.22_element

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> I think this may be another bug, but once an OpenSearch engine is installed it
> should use the URI from the <Image> element as per the specification.

The Firefox search service does use the URI from the <Image> element as the engine's icon. If you're seeing otherwise, you should file a bug!

Comment 5

[rb]

In my case, with an HTML document I created, when using javascript (window.external.AddSearchProvider(xmllocation)) the favicon specified within the document (using a "link"-element) is used instead of the OpenSearch description file's image element.

When using the 'Add "{ENGINE-TITLE}"' item, after loading the XML, firefox sends out a request to retrieve /favicon.ico from the server (which yields a 404 response), and does not associate an icon with the search-provider at all.

I find both cases' behavior unintuitive, and suspect they might be not working as intended. 

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> In my case, with an HTML document I created, when using javascript
> (window.external.AddSearchProvider(xmllocation)) the favicon specified within
> the document (using a "link"-element) is used instead of the OpenSearch
> description file's image element.
> 
> When using the 'Add "{ENGINE-TITLE}"' item, after loading the XML, firefox
> sends out a request to retrieve /favicon.ico from the server (which yields a
> 404 response), and does not associate an icon with the search-provider at all.

Both of those cases shouldn't happen - the only code that tries to retrieve favicon.ico from the server is the one that populates the search engine menu when a page is loaded with a <link rel="search">. If you have evidence to the contrary, please file a new bug.

Comment 7

[rb]

The page does indeed contain a <link rel="search"> for OpenSearch-autodiscovery, so my guess is the code you've been talking about actually does get called.
But, personally, I'd expect such behavior only as a fallback to fetching the icon from the description xml's image element, if at all, and further expect autodiscovery and .AddSearchProvider() to behave the same.
 

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> But, personally, I'd expect such behavior only as a fallback to fetching the
> icon from the description xml's image element

Yes, that's what this bug report is about.

Comment 10

[Andrés Delfino]

Could someone please set version to Trunk and Hardware/OS to: All ?

Comment 12

[Geoff Lawrence]

I am seeing this very issue with Firefox ESR 31.4.0 on CentOS 7, the Apache Httpd logs confirm this. The favicon is set correctly to the specific path in the HTML, the /opensearch.xml is correct and indeed when the search engine is installed it gets the correct icon. The problem occurs when the search engine list is first dropped down to add it, Firefox then tries /favicon.ico instead of either checking the html of the page or the /opensearch.xml for the correct icon. I believe looking at the opensearch.xml would be the best solution.

Comment 13

[Mark Banner (:standard8)]

As far as I can tell (tried on Ecosia.com and elsewhere), we now use the same icon as the browser uses for the page in the tab. Hence closing as works for me.

Bug 1457069 is for considering what to do about favicons and titles in the xml verses those offered by the side.