1420225 - Read legacy files when scanning for Sources in transforms

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Fluent Migration, enhancement)

Description

[Staś Małolepszy :stas]

Right now calling ctx.maybe_add_localization is required to set up the migration context and read legacy translation files.

    ctx.maybe_add_localization(
        'mobile/android/chrome/aboutDownloads.dtd')

    ctx.add_transforms('mobile/about_downloads.ftl', 'about_downloads.ftl', [
        FTL.Message(
            id=FTL.Identifier('title'),
            value=COPY(
                'mobile/android/chrome/aboutDownloads.dtd',
                'aboutDownloads.title'
            )
        )
    ])

There's redundancy between maybe_add_localization and COPY's first argument.

Since we already scan all transforms for instances of Source (which COPY also is) to create a dependency chart of translations needed for each transform, it should be possible to read those legacy files during that scan and remove maybe_add_localization.

I would also like to encourage the use of keyword arguments in calls to add_transforms: target, template and transforms, like so:

    ctx.add_transforms(
        target='mobile/about_downloads.ftl',
        template='about_downloads.ftl',
        transforms=[
            FTL.Message(
                id=FTL.Identifier('title'),
                value=COPY(
                    'mobile/android/chrome/aboutDownloads.dtd',
                    'aboutDownloads.title'
                )
            )
        ]
    )

Comment 1

[Staś Małolepszy :stas]

Attachment: Pull Request

Comment 2

[Staś Małolepszy :stas]

https://github.com/projectfluent/python-fluent/commit/eb6bab11cae9ffccfdacd085b52d572f9f1997c8