Closed
Bug 1420254
Opened 7 years ago
Closed 7 years ago
Add additional Theme API colors to TB
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 59.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files, 1 obsolete file)
842 bytes,
application/octet-stream
|
Details | |
11.16 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
FX has added some themeAPI colors. This are: - toolbar_top_separator, the color of the toolbar top border and tabs border - toolbar_bottom_separator, the color of the toolbar bottom border - tab_text, the text color of the active tab - toolbar_field_border, the search field border color
Assignee | ||
Comment 1•7 years ago
|
||
Jörg doesn't accept reviews. Aceman, could you review it? I'll attach a test theme for trying.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8931466 -
Flags: review?(acelists)
Assignee | ||
Comment 2•7 years ago
|
||
With this theme the bottom toolbar border is red, the top border blue. The active tab text is black. the search field border is white. Don't use it too long to not become eye cancer. ;)
Attachment #8931468 -
Attachment mime type: application/x-xpinstall → application/octet-stream
(In reply to Richard Marti (:Paenglab) from comment #2) > Created attachment 8931468 [details] > test-webext-theme.xpi > > With this theme the bottom toolbar border is red, the top border blue. The > active tab text is black. the search field border is white. I don't see exactly these colors. I see no bottom toolbar border. Top border IS blue. Active tab text (name) IS black. Search field border (e.g. on quick filter bar) is grey, and blue when focused. I also see a green-pink checkerboard as background of main menu and tab bar. Also labels of main toolbar buttons are red. Background of main toolbar and status bar is green.
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to :aceman from comment #3) > (In reply to Richard Marti (:Paenglab) from comment #2) > > Created attachment 8931468 [details] > > test-webext-theme.xpi > > > > With this theme the bottom toolbar border is red, the top border blue. The > > active tab text is black. the search field border is white. > > I don't see exactly these colors. > > I see no bottom toolbar border. > Top border IS blue. Great, tested on all platforms except Linux. And Linux makes it different. :( -> fixed. > Active tab text (name) IS black. > Search field border (e.g. on quick filter bar) is grey, and blue when > focused. Focused is okay when it's blue. > I also see a green-pink checkerboard as background of main menu and tab bar. > Also labels of main toolbar buttons are red. > Background of main toolbar and status bar is green. That's all correct. This test theme checks all possible themeAPI colors.
Attachment #8931466 -
Attachment is obsolete: true
Attachment #8931466 -
Flags: review?(acelists)
Attachment #8931618 -
Flags: review?(acelists)
Comment on attachment 8931618 [details] [diff] [review] additional-themeAPI-colors.patch Review of attachment 8931618 [details] [diff] [review]: ----------------------------------------------------------------- OK, thanks, now I also see red bottom border of main toolbar.
Attachment #8931618 -
Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/e716b8199c2d Add additional Theme API colors to TB. r=aceman
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 59.0
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•