Add additional Theme API colors to TB

RESOLVED FIXED in Thunderbird 59.0

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 59.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

2 years ago
FX has added some themeAPI colors.

This are:
- toolbar_top_separator, the color of the toolbar top border and tabs border
- toolbar_bottom_separator, the color of the toolbar bottom border
- tab_text, the text color of the active tab
- toolbar_field_border, the search field border color
Assignee

Comment 1

2 years ago
Jörg doesn't accept reviews. Aceman, could you review it?

I'll attach a test theme for trying.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8931466 - Flags: review?(acelists)
Assignee

Comment 2

2 years ago
With this theme the bottom toolbar border is red, the top border blue. The active tab text is black. the search field border is white.

Don't use it too long to not become eye cancer. ;)

Updated

2 years ago
Attachment #8931468 - Attachment mime type: application/x-xpinstall → application/octet-stream

Comment 3

2 years ago
(In reply to Richard Marti (:Paenglab) from comment #2)
> Created attachment 8931468 [details]
> test-webext-theme.xpi
> 
> With this theme the bottom toolbar border is red, the top border blue. The
> active tab text is black. the search field border is white.

I don't see exactly these colors.

I see no bottom toolbar border.
Top border IS blue.
Active tab text (name) IS black.
Search field border (e.g. on quick filter bar) is grey, and blue when focused.

I also see a green-pink checkerboard as background of main menu and tab bar.
Also labels of main toolbar buttons are red.
Background of main toolbar and status bar is green.
Assignee

Comment 4

2 years ago
(In reply to :aceman from comment #3)
> (In reply to Richard Marti (:Paenglab) from comment #2)
> > Created attachment 8931468 [details]
> > test-webext-theme.xpi
> > 
> > With this theme the bottom toolbar border is red, the top border blue. The
> > active tab text is black. the search field border is white.
> 
> I don't see exactly these colors.
> 
> I see no bottom toolbar border.
> Top border IS blue.

Great, tested on all platforms except Linux. And Linux makes it different. :( -> fixed.

> Active tab text (name) IS black.
> Search field border (e.g. on quick filter bar) is grey, and blue when
> focused.

Focused is okay when it's blue.

> I also see a green-pink checkerboard as background of main menu and tab bar.
> Also labels of main toolbar buttons are red.
> Background of main toolbar and status bar is green.

That's all correct. This test theme checks all possible themeAPI colors.
Attachment #8931466 - Attachment is obsolete: true
Attachment #8931466 - Flags: review?(acelists)
Attachment #8931618 - Flags: review?(acelists)

Comment 5

2 years ago
Comment on attachment 8931618 [details] [diff] [review]
additional-themeAPI-colors.patch

Review of attachment 8931618 [details] [diff] [review]:
-----------------------------------------------------------------

OK, thanks, now I also see red bottom border of main toolbar.
Attachment #8931618 - Flags: review?(acelists) → review+
Assignee

Comment 6

2 years ago
Thanks. :)
Keywords: checkin-needed

Comment 7

2 years ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e716b8199c2d
Add additional Theme API colors to TB. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

2 years ago
Target Milestone: --- → Thunderbird 59.0

Updated

2 years ago
Blocks: 1347190, 1418603

Updated

2 years ago
Blocks: 1415872
You need to log in before you can comment on or make changes to this bug.