1415872 - Implement colors.tab_text and colors.background_tab_text

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement, P5)

Comment 1

[Tim Nguyen :ntim]

Split this off bug 1347188

Comment 2

[Mike de Boer [:mikedeboer]]

Why do you need to split this off from that bug? It looks quite actionable as it is, currently.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1415872 - Implement colors.tab_text and colors.background_tab_text.

Review commit: https://reviewboard.mozilla.org/r/198132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198132/

Comment 4

[Tim Nguyen :ntim]

My patch only covers the text properties.

Besides, bug 1347188 contains some unanswered questions (notably around colors.background_tab and tints.background_tab).

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8926882 [details]
Bug 1415872 - Implement colors.tab_text and colors.background_tab_text.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198132/diff/1-2/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8926882 [details]
Bug 1415872 - Implement colors.tab_text and colors.background_tab_text.

https://reviewboard.mozilla.org/r/198132/#review204694

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa3d66cd3c40
Implement colors.tab_text and colors.background_tab_text. r=jaws

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out changeset aa3d66cd3c40 (bug 1415872) for ES failure in toolkit/components/extensions/test/browser/head.js

https://hg.mozilla.org/integration/autoland/rev/36c3823f9647dbc80bea8bc4cff7137803e2bc12

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aa3d66cd3c40a28812993955e0a42bdb0282f7cf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8926882 [details]
Bug 1415872 - Implement colors.tab_text and colors.background_tab_text.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198132/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419c69148ec9
Implement colors.tab_text and colors.background_tab_text. r=jaws

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/419c69148ec9

Comment 12

[Madalin Cotetiu]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 13

[Will Bamberg [:wbamberg]]

Documented at https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme.