1420543 - Possible keyword renames: footprint, mlk and topmlk

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task, P3)

Description

[Kohei Yoshino [:kohei]]

I don't know how to get a consensus here, but IMO it's difficult to discover and understand the footprint and mlk keywords. Can we rename those to memory-footprint and memory-leak respectively so typing "memory" in the keyword field will filter both easily?

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Propeosed change to memory-related keywords

As you triage many bugs using these keywords, we're asking your feedback on a readability change. Thank you.

Comment 2

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Kohei, I've asked some triagers about this change.

Comment 3

[Andrew Overholt [:overholt]]

I never use these keywords but the new clarity makes sense to me :)

Comment 4

[Jet Villegas (inactive)]

I asked about this in the #memshrink irc channel. Not sure if they'll have feedback, but LGTM.

Comment 5

[Wayne Mery (:wsmwk)]

increased clarity would definitely be good. Consider - some cases where footprint was used instead of leak (IMO): bug 1392137, bug 1421094, bug 1364743, bug 1387395

I wonder if footprint is even a good enough term (sorry, I don't have alternative ATM)

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8931829 [details]
Propeosed change to memory-related keywords

No opinion, so why not :)

Comment 7

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Keywords edited. Firefox, Thunderbird, and dev-planning lists notified.