Resend option in netmonitor
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(firefox68 fixed)
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: interghost, Assigned: tanhengyeow, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Updated•7 years ago
|
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Hi Honza
Does the current patch need more work on it? Would be glad to tie up any loose ends if so :)
Comment 18•6 years ago
|
||
(In reply to Heng Yeow (:tanhengyeow) from comment #17)
Hi Honza
Does the current patch need more work on it? Would be glad to tie up any loose ends if so :)
I was just testing this and:
- The Network panel context menu has new "Resend" menu item, but it doesn't seem to work
- The Console panel doesn't have the menu at all
See comment #7 for summary of what should be done here.
Thanks!
Honza
Updated•6 years ago
|
Assignee | ||
Comment 19•6 years ago
|
||
Add resend option in the context menu of netmonitor.
Assignee | ||
Comment 20•6 years ago
|
||
Hi Honza
The attached patch does the following:
- When a context menu is clicked, the
Resend
option appears on top of theEdit and Resend
option. - When the
Resend
option is clicked, the same request is sent and appears at the bottom (signifies latest request). The request is also highlighted at the same time.
Would like to get your feedback on the patch :) Also, should I file a separate bug in the Console
component for work to be done in the Console panel as well?
Comment 21•6 years ago
|
||
(In reply to Heng Yeow (:tanhengyeow) from comment #20)
Hi Honza
The attached patch does the following:
- When a context menu is clicked, the
Resend
option appears on top of theEdit and Resend
option.- When the
Resend
option is clicked, the same request is sent and appears at the bottom (signifies latest request). The request is also highlighted at the same time.Would like to get your feedback on the patch :) Also, should I file a separate bug in the
Console
component for work to be done in the Console panel as well?
Thanks!
Feedback posted to Phabricator
Also, should I file a separate bug in the
Console
component for work to be done in the Console panel as well?
Yes, please
Honza
Assignee | ||
Comment 22•6 years ago
|
||
Hi Honza
Updated the patch shown in Phabricator and also filed the bug which can be seen in this Bug 1530138.
Assignee | ||
Comment 24•6 years ago
|
||
Hi Honza
Updated the patch as seen in Phabricator.
Try results here for reference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a4112eef6f95b3ea85ddde84396d0123c22d206
Comment 25•6 years ago
|
||
Updated•6 years ago
|
Comment 26•6 years ago
|
||
bugherder |
Comment 27•6 years ago
•
|
||
I filled a follow up bug 1536828 for implementing "Resend" also in the Console panel.
Honza
Comment 28•6 years ago
|
||
Added this to the Network Request list context menu:
Resend
The Resend context menu option allows you to resend the request as it was originally sent with no changes made.
Description
•