1530138 - Resend option in Console

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Hengyeow (:tanhengyeow)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36

Steps to reproduce:

Similar to the patch in Bug 1422014, let's have this following feature:

The Console panel context menu should have this new "Resend" item too (only when clicking on a request).

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is already one action related to HTTP requests in the Console panel: openNetworkPanel

Search across the Console panel code base shows the following occurrences:
https://searchfox.org/mozilla-central/search?q=openNetworkPanel&path=

I think that the new Resend action could be done similarly.

@Nicolas: does that make sense or is there a better way?

Honza

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Are we talking about having only a Resend action (which doesn't show any UI), or the Edit and resend one?
If it's only Resend, it makes sense to call the function responsible of that from Netmonitor.
if it's Edit and resend, I'd rather not jump the user to the Netmonitor and show the edit form directly in the console.

(Also, at some point we should cleanup the console context menu, and reorganize elements there)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Nicolas Chevobbe from comment #4)

Are we talking about having only a Resend action (which doesn't show any UI), or the Edit and resend one?

Just "Resend"

If it's only Resend, it makes sense to call the function responsible of that from Netmonitor.

Netmonitor's sendCustomRequest is implemented here:
https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/devtools/client/netmonitor/src/actions/requests.js#49

Honza

Comment 6

[Paarmita Bhargava]

Hey Honza, I would like to work on it. Can you please assign it to me?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Hello Paarmita.
It looks like you're assigned on 6 bugs at the moment.
Before taking anything new, it would be better if you finish those.
Also, you already fixed a few good-first-bugs, and we want to keep them for the actual first bug of new contributors :)

Comment 8

[Christoph Walcher]

Attachment: Bug 1530138 - Added resend option in WebConsole

Added resend option in WebConsole

Comment 9

[Christoph Walcher]

Hi Nicolas, I've just pushed an initial patch. Could you assign this bug to me please?

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Hello Christoph, thanks for working on this!
The bug is now assigned to you, and I'll review your patch soon :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc20a50efcf1
Added resend option in WebConsole r=nchevobbe,Honza

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dc20a50efcf1

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Thanks a lot Christoph, the bug is now resolved and is in today's Nightly :)
People seems to like it! https://twitter.com/nicolaschevobbe/status/1128567240247402496