Closed Bug 1530138 Opened 5 years ago Closed 5 years ago

Resend option in Console

Categories

(DevTools :: Console, enhancement, P3)

67 Branch
enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: tanhengyeow, Assigned: christoph-wa)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36

Steps to reproduce:

Similar to the patch in Bug 1422014, let's have this following feature:

The Console panel context menu should have this new "Resend" item too (only when clicking on a request).

Thanks for the report!

Honza

Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Severity: normal → enhancement

There is already one action related to HTTP requests in the Console panel: openNetworkPanel

Search across the Console panel code base shows the following occurrences:
https://searchfox.org/mozilla-central/search?q=openNetworkPanel&path=

I think that the new Resend action could be done similarly.

@Nicolas: does that make sense or is there a better way?

Honza

Flags: needinfo?(nchevobbe)

Are we talking about having only a Resend action (which doesn't show any UI), or the Edit and resend one?
If it's only Resend, it makes sense to call the function responsible of that from Netmonitor.
if it's Edit and resend, I'd rather not jump the user to the Netmonitor and show the edit form directly in the console.

(Also, at some point we should cleanup the console context menu, and reorganize elements there)

Flags: needinfo?(nchevobbe)

(In reply to Nicolas Chevobbe from comment #4)

Are we talking about having only a Resend action (which doesn't show any UI), or the Edit and resend one?

Just "Resend"

If it's only Resend, it makes sense to call the function responsible of that from Netmonitor.

Netmonitor's sendCustomRequest is implemented here:
https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/devtools/client/netmonitor/src/actions/requests.js#49

Honza

Hey Honza, I would like to work on it. Can you please assign it to me?

Hello Paarmita.
It looks like you're assigned on 6 bugs at the moment.
Before taking anything new, it would be better if you finish those.
Also, you already fixed a few good-first-bugs, and we want to keep them for the actual first bug of new contributors :)

Type: defect → enhancement

Added resend option in WebConsole

Hi Nicolas, I've just pushed an initial patch. Could you assign this bug to me please?

Flags: needinfo?(nchevobbe)

Hello Christoph, thanks for working on this!
The bug is now assigned to you, and I'll review your patch soon :)

Assignee: nobody → christoph-wa
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc20a50efcf1
Added resend option in WebConsole r=nchevobbe,Honza
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Thanks a lot Christoph, the bug is now resolved and is in today's Nightly :)
People seems to like it! https://twitter.com/nicolaschevobbe/status/1128567240247402496

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: