1422408 - Wrong Japanese font selected on jisho.org

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Thomas Daede [:TD-Linux]]

Attachment: with webrender

A super pixely font is selected for large characters on jisho.org when Webrender is on.

Comment 1

[Thomas Daede [:TD-Linux]]

Attachment: without webrender

Comment 2

[Lee Salzman [:lsalzman]]

Which version of Firefox are you using? I am not able to reproduce this, as it might be fixed in nightly by bug 1413793.

Comment 3

[Thomas Daede [:TD-Linux]]

Latest Nightly, 59.0a1 (2017-12-04), it still reproduces.

It might be Linux specific, as Bug 1408117 is.

Comment 4

[Lee Salzman [:lsalzman]]

(In reply to Thomas Daede [:TD-Linux] from comment #3)
> Latest Nightly, 59.0a1 (2017-12-04), it still reproduces.
> 
> It might be Linux specific, as Bug 1408117 is.

The platform I tried to reproduce on was Linux.

Comment 5

[Lee Salzman [:lsalzman]]

(In reply to Lee Salzman [:lsalzman] from comment #4)
> (In reply to Thomas Daede [:TD-Linux] from comment #3)
> > Latest Nightly, 59.0a1 (2017-12-04), it still reproduces.
> > 
> > It might be Linux specific, as Bug 1408117 is.
> 
> The platform I tried to reproduce on was Linux.

Can you see what font it is trying to select, then use fc-match from console to see what it ends up routing to? Just a guess, but if it's a combination of a bitmap (non-scalable) font, and the webpage uses a content transform, it miiiight produce symptoms like that. But this would be rather odd and user specific, rather than just platform specific.

Comment 6

[Thomas Daede [:TD-Linux]]

Using fc-match the first font that returns something other than "DejaVu Sans" is the "ＭＳ ゴシック" entry (MS Gothic) which is a font I have explicitly installed in my system, which is why it doesn't reproduce for you (presumably for you it hits the san-serif at the end of the font). MS Gothic is a really old font with both bitmaps and outlines (I have it installed because some programs depend on the exact pixel spacing).

Comment 7

[Lee Salzman [:lsalzman]]

(In reply to Thomas Daede [:TD-Linux] from comment #6)
> Using fc-match the first font that returns something other than "DejaVu
> Sans" is the "ＭＳ ゴシック" entry (MS Gothic) which is a font I have explicitly
> installed in my system, which is why it doesn't reproduce for you
> (presumably for you it hits the san-serif at the end of the font). MS Gothic
> is a really old font with both bitmaps and outlines (I have it installed
> because some programs depend on the exact pixel spacing).

Could you email me the font and the fontconfig file you are using to set up this font on your system, to ease repro for me?

Comment 8

[Lee Salzman [:lsalzman]]

Tracked this down to a problem dealing with fonts that provide both embedded bitmaps and scalable outlines. We're always selecting the embedded bitmaps in WebRender when available, which is not how Skia normally behaves. We have to choose between outline or bitmaps depending on whether the final resolved size actually many any available strikes.

Will take a couple days to properly engineer a fix.

Comment 9

[Lee Salzman [:lsalzman]]

This will be resolved by WR PR https://github.com/servo/webrender/pull/2198