1422563 - Firefox Ignores browser.display.use_system_colors

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P5)

Description

[Carlo Abelli]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171130105051

Steps to reproduce:

1. Use Firefox with dark GTK theme
2. Make sure browser.display.use_system_colors is set to false
3. Open the default new tab page

Seems to be the same as https://bugzilla.mozilla.org/show_bug.cgi?id=232227


Actual results:

1. The search bar is dark (the color of the GTK theme)


Expected results:

1. The search bar should be some default color (presumably white)

Comment 1

[Carlo Abelli]

Note that this is not an issue exclusive to the new tab page (which was only an example). The problem occurs for other pages where the the input colors are not specified explicitly e.g. https://jsfiddle.net/yejqL2oz/

Comment 2

[Pascal Chevrel (relman team) -> :pascalc]

Martin, does it fall into your bucket? This was mentioned recently through our support channels as a still valid bug on Nightly 66 and I wonder if this is not a dupe of https://bugzilla.mozilla.org/show_bug.cgi?id=1283086. Thanks

Comment 3

[Martin Stránský [:stransky] (ni? me)]

I'm going to look at it after 65 release.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

browser.display.use_system_colors is not ignored, it works but a different way how it's expected. browser.display.use_system_colors affects only [1]:

LookAndFeel::eColorID_WindowForeground
LookAndFeel::eColorID_WindowBackground

but we have many of the text/background colors [2].

A variant of the browser.display.use_system_colors is ui.use_standins_for_native_color/ui.use_native_colors introduced in Bug 232227 which provides more color override values.

The colors can be simply verified at about:blank or about:support pages.

But all those settings don't fix the main issue here that the control background is rendered as system styled widget regardless of the settings. There are usually two error cases when system dark theme is selected:

• html page does not define any widget background color. Widgets are rendered as text white on black background which looks ugly on the pages. When ui.use_standins_for_native_color is set we have black text on black background.

• html page defines only background color (usually white/light) - we have white on white unless ui.use_standins_for_native_color is set.

So I'd say that the browser.display.use_system_colors is actually confusing and should go away and we may go with Bug 1527048 until native theming is removed from content.

[1] https://dxr.mozilla.org/mozilla-central/rev/725cc368d14453980d6e0b112edc263a12463ffe/layout/style/PreferenceSheet.cpp#71
[2] https://dxr.mozilla.org/mozilla-central/rev/725cc368d14453980d6e0b112edc263a12463ffe/widget/gtk/nsLookAndFeel.cpp#270

Comment 5

[Martin Stránský [:stransky] (ni? me)]

I think we may replace browser.display.use_system_colors with ui.use_standins_for_native_color/ui.use_native_colors at least to override all possible colors when the checkbox is set.

And also set browser.display.use_system_colors to true by default to keep the recent state when browser.display.use_system_colors has no effect. We also should not use eColorID_WindowForeground, eColorID_WindowBackground as base web page colors in any case.

Dao, what do you think?

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613

Comment 7

[Tim Nguyen :ntim]

Maybe emilio/morgan will be in a better position to answer this? :)

Comment 8

[Emilio Cobos Álvarez [:emilio]]

This should be fixed by the non-native-theme effectively. It should never use system colors except for the accent color.

Comment 0 shouldn't reproduce on Nightly either (even without that) because we have widget.content.allow-gtk-dark-theme=false by default. I don't know when that was implemented.

So unless I'm missing something this is WFM, unless Martin disagrees?

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

This should be fixed by the non-native-theme effectively. It should never use system colors except for the accent color.

Comment 0 shouldn't reproduce on Nightly either (even without that) because we have widget.content.allow-gtk-dark-theme=false by default. I don't know when that was implemented.

So unless I'm missing something this is WFM, unless Martin disagrees?

No objections :)