1423639 - Port some in-content preferences style changes to TB

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1419867 and bug 1422100B changed some styles in FX prefs.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: inContentPrefsChanges.patch

This is the full patch for the review. I'll attach two patches for easier review/correlation with the m-c changes.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: noBoldMenulistText.patch

This is the port of https://hg.mozilla.org/mozilla-central/rev/ea36d9fc714f

Comment 3

[Richard Marti (:Paenglab)]

Attachment: refactorInContent.patch

This is the port of https://hg.mozilla.org/mozilla-central/rev/b59a30cbdbff

Comment 4

[Richard Marti (:Paenglab)]

I hope this makes the review easier.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8935040 [details] [diff] [review]
noBoldMenulistText.patch

I'm looking at these separately. This looks like a straight port. Any objections to landing two changesets here?

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8935041 [details] [diff] [review]
refactorInContent.patch

Looks like an straight forward port as well. I applied the two separate patches and saw not difference. Should there be any?

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8935038 [details] [diff] [review]
inContentPrefsChanges.patch

Folding the two separate patches (with hg qfold) gives this patch. Richard can decide whether to land the folded patch or the separate ones.

Note that the folded one has a typo:
Bug 1422100B: Refactor in-content UI font sizes.
           ^

Comment 8

[Richard Marti (:Paenglab)]

I'm okay with land them separate. Then also the typo needs no additional work. ;)

Comment 9

[Jorg K (CEST = GMT+2)]

OK, but the reviewer likes his questions to be answered ;-(
> I applied the two separate patches and saw not difference. Should there be any?

Comment 10

[Richard Marti (:Paenglab)]

No, there are no differences. I thought it would be easier for the check-in with only one patch.

Comment 11

[Jorg K (CEST = GMT+2)]

I can land as many patches as necessary. Usually it's better to keep different things apart, unless it's a "roll-up" patch. I added the bug number to the separate patches and it's all ready to go tonight together with other patches.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c9cb2d57063e
Port bug 1419867 to TB: prevent menulist labels from getting bolder when they're under a caption. r=jorgk
https://hg.mozilla.org/comm-central/rev/bfe09fa01a6d
Port bug 1422100 to TB: Refactor in-content UI font sizes. r=jorgk