Closed Bug 1423639 Opened 3 years ago Closed 3 years ago

Port some in-content preferences style changes to TB

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1419867 and bug 1422100B changed some styles in FX prefs.
Attached patch inContentPrefsChanges.patch (obsolete) — Splinter Review
This is the full patch for the review. I'll attach two patches for easier review/correlation with the m-c changes.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8935038 - Flags: review?(jorgk)
I hope this makes the review easier.
Comment on attachment 8935040 [details] [diff] [review]
noBoldMenulistText.patch

I'm looking at these separately. This looks like a straight port. Any objections to landing two changesets here?
Attachment #8935040 - Flags: review+
Comment on attachment 8935041 [details] [diff] [review]
refactorInContent.patch

Looks like an straight forward port as well. I applied the two separate patches and saw not difference. Should there be any?
Attachment #8935041 - Flags: review+
Comment on attachment 8935038 [details] [diff] [review]
inContentPrefsChanges.patch

Folding the two separate patches (with hg qfold) gives this patch. Richard can decide whether to land the folded patch or the separate ones.

Note that the folded one has a typo:
Bug 1422100B: Refactor in-content UI font sizes.
           ^
Attachment #8935038 - Flags: review?(jorgk) → review+
I'm okay with land them separate. Then also the typo needs no additional work. ;)
Keywords: checkin-needed
Attachment #8935038 - Attachment is obsolete: true
OK, but the reviewer likes his questions to be answered ;-(
> I applied the two separate patches and saw not difference. Should there be any?
No, there are no differences. I thought it would be easier for the check-in with only one patch.
I can land as many patches as necessary. Usually it's better to keep different things apart, unless it's a "roll-up" patch. I added the bug number to the separate patches and it's all ready to go tonight together with other patches.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c9cb2d57063e
Port bug 1419867 to TB: prevent menulist labels from getting bolder when they're under a caption. r=jorgk
https://hg.mozilla.org/comm-central/rev/bfe09fa01a6d
Port bug 1422100 to TB: Refactor in-content UI font sizes. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
You need to log in before you can comment on or make changes to this bug.