1423731 - Update OpenVR to 1.0.18

Status: RESOLVED FIXED

(Core :: WebVR, enhancement, P2)

Description

[:kip (Kearwood Gilbert)]

The latest version of OpenVR, 1.0.11, has recently been released and we should update our embedded version.

The release notes mention that this update fixes a memory leak on macOS, which could possibly help with bug 1406018.

Comment 2

[Tom Ritter [:tjr]]

This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.

openvr is currently at version 1.0.8. in mozilla-central, and the latest version of the library released is 1.0.12. 

I fetched the latest version of the library from https://github.com/ValveSoftware/openvr/.

Comment 3

[Tom Ritter [:tjr]]

1.0.13 is released

Comment 4

[Tom Ritter [:tjr]]

1.0.14 is released

Comment 5

[:kip (Kearwood Gilbert)]

1.0.18 is released.

Comment 6

[:kip (Kearwood Gilbert)]

Attachment: Bug 1423731 - Update OpenVR to 1.0.18

Review commit: https://reviewboard.mozilla.org/r/242190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242190/

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8973829 [details]
Bug 1423731 - Update OpenVR to 1.0.18

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242190/diff/1-2/

Comment 8

[:kip (Kearwood Gilbert)]

Fixed try failures, due to new enum value for controller handed-ness.  Once try passes, will assign for review.

Comment 9

[:kip (Kearwood Gilbert)]

Comment on attachment 8973829 [details]
Bug 1423731 - Update OpenVR to 1.0.18

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242190/diff/2-3/

Comment 10

[Randall Barker [:rbarker]]

Comment on attachment 8973829 [details]
Bug 1423731 - Update OpenVR to 1.0.18

https://reviewboard.mozilla.org/r/242190/#review249626

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e413c80dee21
Update OpenVR to 1.0.18 r=rbarker

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e413c80dee21

Comment 13

[Tom Ritter [:tjr]]

kip do you know what happened to upstream? It seems like they rewrote history and changed tags....
https://github.com/ValveSoftware/openvr/commits/master

Comment 14

[:kip (Kearwood Gilbert)]

(In reply to Tom Ritter [:tjr] from comment #13)
> kip do you know what happened to upstream? It seems like they rewrote
> history and changed tags....
> https://github.com/ValveSoftware/openvr/commits/master

This would not surprise me.  It appears that most OpenVR development happens outside of GitHub, then releases are snapshotted and shared to the public GitHub repo.

When updating our copy of OpenVR runtime code, I usually grab their master and do a manual diff against our copy as a sanity check to ensure that there weren't unanticipated major refactors.  Any changes needed after grabbing the master are documented in our readme.mozilla file -- these are minimal and don't seem to change often.