1424323 - Stop trying to upload symbols from Windows build jobs

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

bug 1424236 broke symbol uploads from nightlies, and I noticed that the Windows nightly build tasks failed. It turns out that Windows build tasks have been running `make uploadsymbols` and uploading symbols, even though there's also an upload-symbols task that runs after them to do that work!

Here's a recent Windows nightly build:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=nightly&selectedJob=150622553

If you look in the log you'll see:
22:18:48     INFO -      export MOZ_AUTOMATION_UPLOAD_SYMBOLS=1
<...>
23:32:47     INFO -  z:/build/build/src/obj-firefox/_virtualenv/Scripts/python.exe -u z:/build/build/src/toolkit/crashreporter/tools/upload_symbols.py 'dist/target.crashreporter-symbols-full.zip'
23:32:47     INFO -  Uploading symbol file "dist/target.crashreporter-symbols-full.zip" to "https://crash-stats.mozilla.com/symbols/upload"
23:32:47     INFO -  Attempt 1 of 5...
23:32:47     INFO -  Uploaded successfully!

and here's the upload-symbols task that ran after it:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=nightly&selectedJob=150659469

We disabled symbol uploads in Linux builds on docker-worker, but never did the same for Windows builds:
https://dxr.mozilla.org/mozilla-central/rev/457b0fe91e0d49a5bc35014fb6f86729cd5bac9b/taskcluster/scripts/builder/build-linux.sh#46

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: bug 1424323 - remove MOZ_AUTOMATION_UPLOAD_SYMBOLS from in-tree mozconfigs.

With all of our builds in Taskcluster now, we should never be uploading
symbols from build tasks. Unfortunately Windows builds were still doing so.
This patch removes MOZ_AUTOMATION_UPLOAD_SYMBOLS from all the in-tree
mozconfigs and a few other places so that it should always default off
(per moz-automation.mk). The rest of the uploadsymbols bits will be
removed once Thunderbird fixes their automation.

This patch was mostly autogenerated by running:
rg --files-with-matches UPLOAD_SYMBOLS browser/config/mozconfigs/ mobile/android/config/mozconfigs/ | xargs sed -ri '/.*UPLOAD_SYMBOLS.*/d'
sed -ri '/.*UPLOAD_SYMBOLS.*/d' build/unix/mozconfig.linux build/mozconfig.win-common build/macosx/local-mozconfig.common build/mozconfig.automation

Then mobile/android/config/mozconfigs/common and
taskcluster/scripts/builder/build-linux.sh were hand-edited.

Review commit: https://reviewboard.mozilla.org/r/206714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206714/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8935840 [details]
bug 1424323 - remove MOZ_AUTOMATION_UPLOAD_SYMBOLS from in-tree mozconfigs.

https://reviewboard.mozilla.org/r/206714/#review212496

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6656f7bbc86
remove MOZ_AUTOMATION_UPLOAD_SYMBOLS from in-tree mozconfigs. r=rillian

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b6656f7bbc86

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d39b5cd2fc78
Keep build files in sync (Port bug 1424323: remove MOZ_AUTOMATION_UPLOAD_SYMBOLS from in-tree mozconfigs). r=tomprince(via IRC)