1425724 - Fix grid column width in Sanitize Dialog in Preferences

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[magicp]

Attachment: settings-for-clearing-history-dialog.png

Steps to reproduce:
1. Launch Nightly
2. Go to about:preferences#privacy > History
3. Switch to Nightly will "Use custom settings for history"
4. Check on "Clear history when Nightly closes"
5. Click "Settings..." button

Actual results:
Left column is too wide and ckeckbox label is wrapped.

Expected results:
Set appropriate column width and checkbox label should be no wrap.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=21c3fcf333f6931e6b18c3c2d169f6081b2af2e1&tochange=b59a30cbdbff45fb037451761289bc8e11800945

Comment 1

[Sagar Bharadwaj]

Attachment: Bug 1425724 - Fixed grid column width in Sanitize dialog in Preferences

Updated column width in corresponding dtd file

Review commit: https://reviewboard.mozilla.org/r/208174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208174/

Comment 2

[Sagar Bharadwaj]

Hello magicp,
I have pushed my patch for this bug to mozreview.

Comment 3

[magicp]

(In reply to Sagar Bharadwaj from comment #2)
> Hello magicp,
> I have pushed my patch for this bug to mozreview.

Unfortunately, I can't review... Could you change reviewer? Thanks.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8937498 [details]
Bug 1425724 - Fixed grid column width in Sanitize dialog in Preferences

https://reviewboard.mozilla.org/r/208174/#review214122

Looks good, thanks!

Comment 5

[Sagar Bharadwaj]

Can you push this to the try server? I do not have access.

Comment 6

[Dão Gottwald [:dao]]

This is simple enough to land without a try run. I already requested landing. It will land on autoland once it reopens.

Comment 7

[Sagar Bharadwaj]

Hello Dao,
Thanks for your review.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4300932758f
Fixed grid column width in Sanitize dialog in Preferences r=dao

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a4300932758f

Comment 10

[Francesco Lodolo [:flod]]

Unfortunately I need to ask for a backout.

Here's the problem: all versions of Firefox, starting from 57, come out of a single localization repository. This problem affects only 59, not 58. If a locale updates this string now, it will impact also 58 builds, not just 59.

We need a different string ID for this, used only in 59 and onwards. That will also make sure that all locales check their value.

Comment 11

[Cristina Coroiu [:ccoroiu]]

Backout: https://hg.mozilla.org/mozilla-central/rev/2ff08db67b917fba1558986f3f2f796260f970f8

Comment 12

[Francesco Lodolo [:flod]]

Should this be duped against bug 1425822, since that's removing completely the string changed in this one?

Comment 13

[Dão Gottwald [:dao]]

I'm going to reland this along with bug 1425822.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dec62f3eeb1
Fixed grid column width in Sanitize dialog in Preferences. r=dao

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5dec62f3eeb1