1426791 - All OSX tests are going to permacrash when Gecko 59 merges to Beta on 2018-01-11

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Should be reproducible with the patch below:
https://hg.mozilla.org/try/rev/0154852baa88e427a1957e67ec1fd9d3e0acd80b

https://treeherder.mozilla.org/logviewer.html#?job_id=153049656&repo=try

PROCESS-CRASH | automation.py | application crashed [@ audioipc_server::channel::{{impl}}::send<audioipc_server::Command>]

Does the newly-enabled OSX AudioIPC code have dependencies on NIGHTLY_BUILD being set?

Comment 1

[Matthew Gregan [:kinetik]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)
> Should be reproducible with the patch below:
> https://hg.mozilla.org/try/rev/0154852baa88e427a1957e67ec1fd9d3e0acd80b
> 
> https://treeherder.mozilla.org/logviewer.html#?job_id=153049656&repo=try
> 
> PROCESS-CRASH | automation.py | application crashed [@
> audioipc_server::channel::{{impl}}::send<audioipc_server::Command>]
> 
> Does the newly-enabled OSX AudioIPC code have dependencies on NIGHTLY_BUILD
> being set?

The pref to enable it is nightly-only.  Looks like we're missing a simple pref test in the bits I added recently, should be a simple fix.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: audioipc_pref.patch

This fixes local macOS testing with remoting prefed off.

Ryan, if you get a chance to push this with the rest of the beta staging changes, that'd be great.  I expect this to address bug 1426791 too.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8938627 [details] [diff] [review]
audioipc_pref.patch

This works great :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4b8ab2281bd
Don't try to activate cubeb remoting without checking pref.  r=kamidphish a=covered-by-inbound

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c4b8ab2281bd