Status

()

enhancement
P2
normal
Rank:
20
ASSIGNED
2 years ago
6 days ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

This bug tracks enabling libcubeb remoting/AudioIPC support on macOS.
The existing sandboxing on macOS prevents remoting from working as-is because AudioIPC relies on establishing the initial server connection via a Unix domain socket in the temp directory.  Bug 1405877 addresses this by moving AudioIPC to a model where the server connection is established in the chrome process and then passed to the requesting content process via fd passing in Gecko's IPC.
Attachment #8937384 - Flags: review?(dglastonbury)
Attachment #8937384 - Flags: review?(dglastonbury) → review+
Comment on attachment 8937384 [details] [diff] [review]
Enable AudioIPC on macOS.  r?kamidphish

Review of attachment 8937384 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't realize the remoting was basically ready to go on macOS, this is great!

Once this lands, are we good to lock down the sandbox policy for audio on macOS, or would you prefer we wait a bit for this to bake?

::: toolkit/library/rust/gkrust-features.mozbuild
@@ +22,5 @@
>  
>  if CONFIG['MOZ_RUST_SIMD']:
>      gkrust_features += ['simd-accel']
>  
>  # This feature is only supported on Linux and this check needs to

This comment needs to be updated.
(In reply to Alex Gaynor [:Alex_Gaynor] from comment #3)
> I didn't realize the remoting was basically ready to go on macOS, this is
> great!
> 
> Once this lands, are we good to lock down the sandbox policy for audio on
> macOS, or would you prefer we wait a bit for this to bake?

We'd prefer to wait a bit.  The macOS audio backend has much tighter latency (and other) constraints than the Linux/PulseAudio backend, so there's a reasonable chance of issues.  At this stage we're enabling this in nightly to shake it down, there's a chance we'll have to pref it off pretty quickly if there's breakage.

> >  # This feature is only supported on Linux and this check needs to
> 
> This comment needs to be updated.

Good catch, thanks.
Great, thanks for the insights.
Rank: 20
Priority: -- → P2
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bded93a4777e
Enable audio remoting (AudioIPC for cubeb) on macOS.  r=kamidphish
https://hg.mozilla.org/mozilla-central/rev/bded93a4777e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1426791
This has degraded audio quality pretty badly, leaving webrtc calls nearly unusable on OS X.
Depends on: 1429847
Per bug 1429847 comment 6, we'll disable remoting while we investigate solutions for the WebRTC issues.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: leave-open
Attachment #8942806 - Flags: review?(dglastonbury)
Attachment #8942806 - Flags: review?(dglastonbury) → review+
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89c02d32a35c
Disable AudioIPC on macOS while investigating fallout.  r=kamidphish

The leave-open keyword is there and there is no activity for 6 months.
:kinetik, maybe it's time to close this bug?

Flags: needinfo?(kinetik)

I'm working on having another go at this.

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #14)

The leave-open keyword is there and there is no activity for 6 months.
:kinetik, maybe it's time to close this bug?

There have been several fixes to resolve the issues that resulted in the original backout, so this bug will be landed again. I've cleared leave-open and marked it as ASSIGNED for now.

Status: REOPENED → ASSIGNED
Flags: needinfo?(kinetik)
Keywords: leave-open

I see a number of failures, even with two threads, but I can repro locally so I'll fix soon. Hopefully it's all the same bug.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44433c9e7372e1b5ba6740be0cf23f473a75c061

Depends on: 1539225
You need to log in before you can comment on or make changes to this bug.