1427204 - Firefox does not save password on www.benefits.ml.com

Status: RESOLVED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Kelly Kane]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

1. Go to https://www.benefits.ml.com/Login/Login
2. Edit autocomplete=on using bookmarlet[1], confirm in dev tools it is on for both username and password.
3. Login successfully.

[1] http://kb.mozillazine.org/User_name_and_password_not_remembered


Actual results:

No prompt to save password.


Expected results:

Prompt to save password.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
20171227100314

Another site that uses XHR. See bug 1150468, comment 2.

(In reply to Kelly Kane from comment #0)
> 2. Edit autocomplete=on using bookmarlet[1]

Autocomplete="off" doesn't prevent Firefox from prompting to save the password since version 38.
https://developer.mozilla.org/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion

Comment 2

[Matthew N. [:MattN]]

Can you please confirm that this works with tomorrow's Firefox Nightly version now that bug 1287202 is fixed? https://nightly.mozilla.org/

Thanks

Comment 3

[Kelly Kane]

Installed Nightly 68.0a1 (2019-03-21) (64-bit) (First time installing a nightly on this computer ever.) Ran it with all default settings.

1. https://www.benefits.ml.com/Login/Login
2. Enter correct username and password. Click login, successfully logs in.
3. Prompted to save (yay) however just the password with a blank username.
4. Enter username, hit save. Verify username and password stored in password manager. Close tab.
5. Clear Data (Options -> Privacy -> Clear Data, leave both boxes checked, confirm) and restart firefox nightly.
6. Visit https://www.benefits.ml.com/Login/Login, username and password not auto-filled. Select password box, little dropdown from the password manager shows the key icon with my username. Click it. Password is filled in, not username. Manually enter username, click Log In. Successfully login.

Partial success - it's definitely capturing that it's a login screen and storing the password, but it's not seeing the username. Sometimes this happens (I think it also happens on https://online.citi.com/US/login.do) but filling in the username typically resolved it.

Tested using this same nightly session https://online.citi.com/US/login.do login, logged in successfully however there is no prompt to save username and password. It does show the little "View Saved Logins" dropdown when I click in the password box.

Comment 4

[Matthew N. [:MattN]]

(In reply to Kelly Kane from comment #3)

Installed Nightly 68.0a1 (2019-03-21) (64-bit) (First time installing a nightly on this computer ever.) Ran it with all default settings.

1. https://www.benefits.ml.com/Login/Login
2. Enter correct username and password. Click login, successfully logs in.
3. Prompted to save (yay) however just the password with a blank username.
4. Enter username, hit save. Verify username and password stored in password manager. Close tab.
5. Clear Data (Options -> Privacy -> Clear Data, leave both boxes checked, confirm) and restart firefox nightly.

Awesome! Glad to hear that and thanks for the detailed write-up. So, technically this bug is resolved since we now save so I've resolved this one and filed bug 1538026 for the username not filling/saving.

Sometimes this happens (I think it also happens on https://online.citi.com/US/login.do) but filling in the username typically resolved it.

Tested using this same nightly session https://online.citi.com/US/login.do login, logged in successfully however there is no prompt to save username and password. It does show the little "View Saved Logins" dropdown when I click in the password box.

The Citi issue is being tracked in bug 1478127 which you can follow if you're interested. I'll be looking into that in the next week or two.

Comment 5

[Kelly Kane]

Thanks! I'm really glad to see such a big jump forward on this!