Closed
Bug 1427897
Opened 8 years ago
Closed 7 years ago
A user should be able to rearrange tabs in the tabs tray
Categories
(Firefox for iOS :: Browser, enhancement, P1)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 11.0 | --- |
People
(Reporter: farhan, Assigned: justindarc)
References
Details
Attachments
(1 file)
Rearranging tabs is a pretty basic feature that we dont have on both iPad and iPhone.
This could be implemented with the new Drag and Drop APIs (I think). And also give us better support in the system.
If we could share the implementation between TopTabs and TabTray we could save a lot of work.
Is it worth backporting this to ios10 as the new Drag APIs are ios11+
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8954166 -
Flags: review?(fpatel)
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8954166 -
Flags: review?(fpatel)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8954166 [details] [review]
GitHub Pull Request
Can you try this out? It still seems fragile to me. To be honest, the more I work with this, the more I think we took the wrong approach. I know we tried to cancel the drag operation when other adds/removes happen because that seemed to be the most fool-proof. However, cancelling drags seems to be completely hit-or-miss :-/
Attachment #8954166 -
Flags: feedback?(fpatel)
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8954166 -
Flags: feedback?(fpatel) → feedback+
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8954166 -
Flags: review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Landed on master:
https://github.com/mozilla-mobile/firefox-ios/commit/0b3538641b561bdd2172c8e82c86090e4f62c64c
Landed on v11.x:
https://github.com/mozilla-mobile/firefox-ios/commit/3b9c84b8ebc37527871412780682a59afc69e791
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•