Remove datetimepicker binding and related ones

RESOLVED FIXED in Firefox 59

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [xbl-unused])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I don't see it being used anywhere. So assume only thunderbird/seamonkey are using it.

https://dxr.mozilla.org/mozilla-central/search?q=datetimepicker&redirect=true

Most of the instances refer to the content date time picker, which is a XUL panel with an iframe to an HTML time picker (which does not use the XBL datetimepicker binding).
(Assignee)

Updated

a year ago
Assignee: nobody → ntim.bugs
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
Notifying :Paenglab for potential comm-central changes.
Flags: needinfo?(richard.marti)
(Assignee)

Updated

a year ago
Whiteboard: [xbl-unused]
Comment hidden (mozreview-request)
Lightning uses his own bindings but TB and SM use them in the Address book for the birthday setting. So we need to port them to c-c.

Thanks for the info.
Flags: needinfo?(richard.marti)
Comment hidden (mozreview-request)

Comment 7

a year ago
mozreview-review
Comment on attachment 8940806 [details]
Bug 1428849 - Remove datetimepicker.xml bindings.

https://reviewboard.mozilla.org/r/211070/#review217160

Thanks! Seems like a sane removal. I'm also pleased that this will help remove some of the confusion between this binding and the DOM datepicker code.

I can't find usage within mozilla-central outside of the tests you removed. I know that there is some usage still in comm-central, but I suspect those folks will be able to move this over to c-c without much trouble.

Assuming a green try push, r=me. Thanks!

::: commit-message-72100:1
(Diff revision 3)
> +Bug 1428849 - Remove datetimepicker binding and related ones. r=mconley

Nit: "related ones" is kinda vague in this context. Perhaps "Remove datetimepicker binding and descendant bindings". Even "Remove datetimepicker binding" is probably sufficient.
Attachment #8940806 - Flags: review?(mconley) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3eba56d0b50f
Remove datetimepicker.xml bindings. r=mconley
Depends on: 1429231
Depends on: 1429232

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3eba56d0b50f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.