1428849 - Remove datetimepicker binding and related ones

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Nguyen :ntim]

I don't see it being used anywhere. So assume only thunderbird/seamonkey are using it.

https://dxr.mozilla.org/mozilla-central/search?q=datetimepicker&redirect=true

Most of the instances refer to the content date time picker, which is a XUL panel with an iframe to an HTML time picker (which does not use the XBL datetimepicker binding).

Comment 1

[Brian Grinstead [:bgrins]]

The only hits I see for "datepicker" or "timepicker" elements are the associated tests (which could also be removed if the bindings go):

https://dxr.mozilla.org/mozilla-central/search?q=%22%3Cdatepicker%22
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/tests/chrome/test_timepicker.xul?q=%22%3Ctimepicker%22&redirect_type=single#13

And the bindings in xul.css:

https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/dist/bin/chrome/toolkit/content/global/xul.css#956-970

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1428849 - Remove datetimepicker.xml bindings.

Review commit: https://reviewboard.mozilla.org/r/211070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211070/

Comment 3

[Tim Nguyen :ntim]

Notifying :Paenglab for potential comm-central changes.

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8940806 [details]
Bug 1428849 - Remove datetimepicker.xml bindings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211070/diff/1-2/

Comment 5

[Richard Marti (:Paenglab)]

Lightning uses his own bindings but TB and SM use them in the Address book for the birthday setting. So we need to port them to c-c.

Thanks for the info.

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8940806 [details]
Bug 1428849 - Remove datetimepicker.xml bindings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211070/diff/2-3/

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8940806 [details]
Bug 1428849 - Remove datetimepicker.xml bindings.

https://reviewboard.mozilla.org/r/211070/#review217160

Thanks! Seems like a sane removal. I'm also pleased that this will help remove some of the confusion between this binding and the DOM datepicker code.

I can't find usage within mozilla-central outside of the tests you removed. I know that there is some usage still in comm-central, but I suspect those folks will be able to move this over to c-c without much trouble.

Assuming a green try push, r=me. Thanks!

::: commit-message-72100:1
(Diff revision 3)
> +Bug 1428849 - Remove datetimepicker binding and related ones. r=mconley

Nit: "related ones" is kinda vague in this context. Perhaps "Remove datetimepicker binding and descendant bindings". Even "Remove datetimepicker binding" is probably sufficient.

Comment 8

[Tim Nguyen :ntim]

Comment on attachment 8940806 [details]
Bug 1428849 - Remove datetimepicker.xml bindings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211070/diff/3-4/

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8940806 [details]
Bug 1428849 - Remove datetimepicker.xml bindings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211070/diff/4-5/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eba56d0b50f
Remove datetimepicker.xml bindings. r=mconley

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3eba56d0b50f