Closed Bug 1428849 Opened 3 years ago Closed 3 years ago
Remove datetimepicker binding and related ones
I don't see it being used anywhere. So assume only thunderbird/seamonkey are using it. https://dxr.mozilla.org/mozilla-central/search?q=datetimepicker&redirect=true Most of the instances refer to the content date time picker, which is a XUL panel with an iframe to an HTML time picker (which does not use the XBL datetimepicker binding).
The only hits I see for "datepicker" or "timepicker" elements are the associated tests (which could also be removed if the bindings go): https://dxr.mozilla.org/mozilla-central/search?q=%22%3Cdatepicker%22 https://dxr.mozilla.org/mozilla-central/source/toolkit/content/tests/chrome/test_timepicker.xul?q=%22%3Ctimepicker%22&redirect_type=single#13 And the bindings in xul.css: https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/dist/bin/chrome/toolkit/content/global/xul.css#956-970
Notifying :Paenglab for potential comm-central changes.
Lightning uses his own bindings but TB and SM use them in the Address book for the birthday setting. So we need to port them to c-c. Thanks for the info.
Comment on attachment 8940806 [details] Bug 1428849 - Remove datetimepicker.xml bindings. https://reviewboard.mozilla.org/r/211070/#review217160 Thanks! Seems like a sane removal. I'm also pleased that this will help remove some of the confusion between this binding and the DOM datepicker code. I can't find usage within mozilla-central outside of the tests you removed. I know that there is some usage still in comm-central, but I suspect those folks will be able to move this over to c-c without much trouble. Assuming a green try push, r=me. Thanks! ::: commit-message-72100:1 (Diff revision 3) > +Bug 1428849 - Remove datetimepicker binding and related ones. r=mconley Nit: "related ones" is kinda vague in this context. Perhaps "Remove datetimepicker binding and descendant bindings". Even "Remove datetimepicker binding" is probably sufficient.
Attachment #8940806 - Flags: review?(mconley) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3eba56d0b50f Remove datetimepicker.xml bindings. r=mconley
You need to log in before you can comment on or make changes to this bug.