1429231 - TB: Restore the datetimepicker bindings/styles after their removal in bug 1428849

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1428849 removes bindings and styles for the datetimepicker. The only usage is the birthday field in AB.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: datetimepicker.patch

I removed the timepicker binding from the XML file which is not used. Bug 1428849 is already in autoland.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8941217 [details] [diff] [review]
datetimepicker.patch

Hmm, large patch. I'll land it when required. rs=jorgk.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aea8da53babb
TB: Restore the datetimepicker bindings/styles after their removal in bug 1428849. r=jorgk

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug1429231-fup.patch

Huh, missed the jar.mn changes somehow. And the arrows in Linux didn't work although it was the same image link in m-c. Maybe they already didn't worked there under Linux (m-c used the Windows file for Linux).

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8941410 [details] [diff] [review]
Bug1429231-fup.patch

Review of attachment 8941410 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/linux/mail/datetimepicker.css
@@ +92,5 @@
>  }
>  
>  .datepicker-next,
>  .datepicker-previous:-moz-locale-dir(rtl) {
> +  list-style-image: url("chrome://messenger/skin/icons/arrow/arrow-right.png");

OK, this changes the image from a GIF that resided in M-C ("global") to an image we maintain in C-C, right? I can find arrow-right.png on my system.

::: mail/themes/windows/mail/datetimepicker.css
@@ +92,5 @@
>  }
>  
>  .datepicker-next,
>  .datepicker-previous:-moz-locale-dir(rtl) {
> +  list-style-image: url("chrome://messenger/skin/icons/arrow/arrow-rit.gif");

Here were're changing from the "global GIF to a GIF in messenger, but I can't see arrow-rit.gif on my system, well, only under suite/ and mozilla/ (global one).

Neither this patch nor part 1 provides that image. What am I missing?

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug1429231-fup.patch

Don't know where my head is and only fixed it half ways. :(

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8941422 [details] [diff] [review]
Bug1429231-fup.patch

My head it bad too today, and I'm about to do more damage ;-(

Comment 8

[Richard Marti (:Paenglab)]

No big damage without this patch. Good for next m-c merge.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f4201af4ba70
Follow-up: Add missing jar.mn changes for Linux and Mac. r=jorgk

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e87932c3f91e
Add missing datepicker locales to SeaMonkey. rs=bustage-fix

Comment 11

[Frank-Rainer Grahl (:frg)]

Maybe we should also look for a common locale dir outside mailnews. Don't see this ever differ in the future.

Comment 12

[Richard Marti (:Paenglab)]

(In reply to Frank-Rainer Grahl (:frg) from comment #11)
> Maybe we should also look for a common locale dir outside mailnews. Don't
> see this ever differ in the future.

When this will be promoted to the translators, okay.

BTW. bug 1429232 exists for SM. ;)

Comment 13

[Frank-Rainer Grahl (:frg)]

> BTW. bug 1429232 exists for SM. ;)

Thanks. I am just losing track with all the Mozilla removals. Just needed a quick build solution.