1428869 - Change progressmeter to be html:progress

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, task, P5)

Description

[Tim Nguyen :ntim]

HTML has the <progress> element, so we can potentially use that.

Comment 1

[Tim Nguyen :ntim]

Attachment: wip-progressmeter.patch

Non working WIP.

Comment 2

[Tim Nguyen :ntim]

After playing with it, I don't think this worth the effort. It doesn't remove an enormous amount of code, and requires to a lot of effort to fix the tests and the styling.

However, we can potentially change `progressmeter` in the future to be a custom element, or simply change everything to a  HTML <progress> element:

* <progressmeter mode="undeterminate"> corresponds to an HTML <progress> with no value.
* the value attribute corresponds to the HTML <progress> value attribute
* the max attribute is also the same as its HTML counterpart

Comment 3

[Brian Grinstead [:bgrins]]

Updated the bug title to match Comment 2

Comment 4

[alexander :surkov (:asurkov)]

sorry, didn't notice this bug when filed bug 1491197

Comment 5

[Tim Nguyen :ntim]

I think we can leave this bug open to change consumers to use html:progress.

Comment 6

[:Paolo Amadini]

Attachment: Bug 1428869 - Use html:progress in front-end code. r=bgrins,mayhemer

Comment 7

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68d02cc5b13178c59a406b359fdb5a6ef473eb72

Comment 8

[:Paolo Amadini]

Setting needinfo for the review of PSM code, since it may disappear from dashboards otherwise.

Comment 9

[Honza Bambas (:mayhemer)]

(In reply to :Paolo Amadini from comment #8)
> Setting needinfo for the review of PSM code, since it may disappear from
> dashboards otherwise.

Yeah, I don't see it my phab.

Comment 10

[:Paolo Amadini]

With a trivial test fix:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=659e5a35a071c98bbfa0d7e96f764a9bc0fc548b

Comment 11

[Honza Bambas (:mayhemer)]

Paolo, I'm not sure why I should review UI changes.  I don't know those parts at all, despite I'm still a PSM peer.  So I don't think I can review your changes well.

Comment 12

[:Paolo Amadini]

Per discussion on IRC, it is fine for someone from the front-end team to rubberstamp this.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6b5c10bba5
Use html:progress in front-end code. r=bgrins,Gijs

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6d6b5c10bba5

Comment 15

[Daniel Bodea [:danibodea]]

Sorry for the lack of knowledge on this matter. I have to ask you to provide some sort of STR that I could use to verify your bug. Thank you.

Comment 16

[:Paolo Amadini]

This bug changed the internal implementation of the progress bar for the following cases:
 - Updating the application, not in the background but through the separate window
 - Setting or changing the Master Password, for the password strength indication
 - Using the Reset Firefox feature
 - Installing an add-on

The cases above are the primary ones, we need to verify that the progress bar is still working. There's also a WebIDE change that we don't need to test specifically, and some less used cases:
 - Setting a password for the Software Security Device in the Security Devices preferences
 - Setting a password when backing up a personal certificate

Checking the latter cases is less important that the first four, since they are more rarely used and steps to reproduce may be more complex, for example they may require generating a personal certificate.

Comment 17

[Daniel Bodea [:danibodea]]

I have verified the functionality and UI of the following cases on Nightly v65.0a1 from 2018-10-23:
 - Updating the application, not in the background but through the separate window
 - Setting or changing the Master Password, for the password strength indication
 - Using the Reset Firefox feature
 - Installing an add-on

No issues stood out while performing these actions multiple times and the progress bar's UI performed as before.
I don't know how to create a personal certificate, so I have skipped testing that part. If you think this is a mandatory test, please provide me with a link/tutorial on how I can create a personal certificate and I will do it.

Thank you!