1499947 - kill xul:progressmeter

Status: RESOLVED FIXED

(Core :: XUL, task, P1)

Description

[alexander :surkov (:asurkov)]

as long as bug 1428869 is fixed, we can kill progressmeter CE (see bug 1491197). 

So 
* rollback bug 1491197
* remove all XULProgressMeterAccessible references https://searchfox.org/mozilla-central/search?q=XULProgressMeterAccessible&case=true&path=
* remove <progressmeter> from XUL testing files https://searchfox.org/mozilla-central/search?q=%3Cprogressmeter&case=true&path=*.xul

Comment 1

[:Paolo Amadini]

There's also the XUL frame and some appearance code that looks for XUL attributes.

Comment 2

[Mats Palmgren (inactive)]

I spawned off removing the XUL frame as bug 1504576.

Comment 3

[:Paolo Amadini]

Attachment: Bug 1499947 - Part 1 - Remove XULProgressMeterAccessible and its base template class. r=Jamie

Depends on D12143

Comment 4

[:Paolo Amadini]

Attachment: Bug 1499947 - Part 2 - Remove the "progressmeter" element and related tests. r=bgrins,bzbarsky

Depends on D12144

Comment 6

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7c5a1abcdf7893d7edd5d2f33470a0dbb682e16

Comment 7

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c265cd57143a5526dda63795afade7c6cbcc9baf

Comment 8

[:Paolo Amadini]

When this lands, uses of the XUL "progressmeter" in comm-central would have to be replaced with the HTML "progress" element, or the current Custom Element could be moved there.

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. I thought we had already replaced all progress metres with HTML in bug 1499593. I'm not missing anything here, am I, Richard?

Comment 10

[:Paolo Amadini]

Is this returning stale results?

https://dxr.mozilla.org/comm-central/search?q=%3Cprogressmeter

Comment 11

[Richard Marti (:Paenglab)]

(In reply to :Paolo Amadini from comment #10)
> Is this returning stale results?
> 
> https://dxr.mozilla.org/comm-central/search?q=%3Cprogressmeter

The footer says last updated at 2018-11-19 22:51. 

Better to use https://searchfox.org/comm-central/search?q=%3Cprogressmeter&case=false&regexp=false&path=

Which shows only one <progressmeter which landed in bug 1496632 after our port to html. So only this needs to be fixed.

Comment 12

[Jorg K (CEST = GMT+2)]

Thanks again, I wasn't aware of the last one which had crept in. Filed bug 1508735 for its removal.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f64862fa1c3
Part 1 - Remove XULProgressMeterAccessible and its base template class. r=Jamie
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e8d51e41a5
Part 2 - Remove the "progressmeter" element and related tests. r=bgrins,bzbarsky

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0f64862fa1c3
https://hg.mozilla.org/mozilla-central/rev/82e8d51e41a5