1428918 - Web Authentication - Enable in Nightly

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/him)]

In advance of enabling in 60 [1], it's time to enable WebAuthn in nightly.


[1] https://groups.google.com/forum/#!msg/mozilla.dev.platform/tsevyqfBHLE/lccldWNNBwAJ

Comment 1

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1428918 - Enable Web Authentication in Nightly

In advance of enabling Web Authentication in Firefox 60 [1], let's turn it on
for Nightly users.

[1] https://groups.google.com/forum/#!msg/mozilla.dev.platform/tsevyqfBHLE/lccldWNNBwAJ

Review commit: https://reviewboard.mozilla.org/r/211168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211168/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8940907 [details]
Bug 1428918 - Enable Web Authentication in Nightly

https://reviewboard.mozilla.org/r/211168/#review217200

\o/

Comment 3

[J.C. Jones [:jcj] (he/him)]

Thanks!!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please keep in mind that any future tests you land will need to take this split into account so you don't end up with permafailing tests on the next merge to Beta when the feature is unexpectedly (to the test harness) disabled.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec2323f6d9e9
Enable Web Authentication in Nightly r=keeler

Comment 6

[J.C. Jones [:jcj] (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Please keep in mind that any future tests you land will need to take this
> split into account so you don't end up with permafailing tests on the next
> merge to Beta when the feature is unexpectedly (to the test harness)
> disabled.

Wilco; we'll keep with the practice of explicitly enabling WebAuthn by pref until it's safely on-by-default everywhere. Thanks, Ryan!

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_interfaces_secureContext.html

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155086841&repo=autoland&lineNumber=24327
Rev: https://hg.mozilla.org/integration/autoland/rev/be77086d684fb35877a3d7cc2fb646abc18835cd

Comment 8

[Narcis Beleuzu [:NarcisB]]

The push was also triggering wpt4 failures on credentialscontainer-create-basics.https.html

TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password data - expected FAIL

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155091670&repo=autoland&lineNumber=1765

Comment 9

[J.C. Jones [:jcj] (he/him)]

Thanks, NarcisB. Forgetting the secureContext.html test is sad but no big deal. I had no idea that we had wpts for Credential Management in-tree, so that's going to need its own bug to handle. Opened Bug 1429171.

Comment 10

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8940907 [details]
Bug 1428918 - Enable Web Authentication in Nightly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211168/diff/1-2/

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8940907 [details]
Bug 1428918 - Enable Web Authentication in Nightly

https://reviewboard.mozilla.org/r/211168/#review217516

::: security/manager/ssl/security-prefs.js:118
(Diff revision 2)
>  // 1: Only collect telemetry. CT qualification checks are not performed.
>  pref("security.pki.certificate_transparency.mode", 0);
>  
>  // Hardware Origin-bound Second Factor Support
>  pref("security.webauth.u2f", false);
> +#ifdef RELEASE_OR_BETA

(Ah, didn't recall we have RELEASE_OR_BETA, when there is also NIGHTLY_BUILD. I guess both work fine.)

Comment 12

[J.C. Jones [:jcj] (he/him)]

Thanks for the review, smaug!

Oops, these need to be marked isSecureContext:true, too [1]. Updating...


[1] https://treeherder.mozilla.org/logviewer.html#?job_id=155345944&repo=try&lineNumber=9488

Comment 13

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8940907 [details]
Bug 1428918 - Enable Web Authentication in Nightly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211168/diff/2-3/

Comment 14

[J.C. Jones [:jcj] (he/him)]

OK, this looks good now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=caf1e4f37ea8ad406df346b5cdf11931f9bdca9f&group_state=expanded

Marking for checkin. With luck, no tree-burning this time!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fb3a7563abc
Enable Web Authentication in Nightly r=keeler,smaug

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2fb3a7563abc