Closed Bug 1428918 Opened 5 years ago Closed 5 years ago
Web Authentication - Enable in Nightly
59 bytes, text/x-review-board-request
In advance of enabling in 60 , it's time to enable WebAuthn in nightly.  https://groups.google.com/forum/#!msg/mozilla.dev.platform/tsevyqfBHLE/lccldWNNBwAJ
Comment on attachment 8940907 [details] Bug 1428918 - Enable Web Authentication in Nightly https://reviewboard.mozilla.org/r/211168/#review217200 \o/
Attachment #8940907 - Flags: review?(dkeeler) → review+
Please keep in mind that any future tests you land will need to take this split into account so you don't end up with permafailing tests on the next merge to Beta when the feature is unexpectedly (to the test harness) disabled.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/ec2323f6d9e9 Enable Web Authentication in Nightly r=keeler
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4) > Please keep in mind that any future tests you land will need to take this > split into account so you don't end up with permafailing tests on the next > merge to Beta when the feature is unexpectedly (to the test harness) > disabled. Wilco; we'll keep with the practice of explicitly enabling WebAuthn by pref until it's safely on-by-default everywhere. Thanks, Ryan!
Backed out for mochitest failures on test_interfaces_secureContext.html Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155086841&repo=autoland&lineNumber=24327 Rev: https://hg.mozilla.org/integration/autoland/rev/be77086d684fb35877a3d7cc2fb646abc18835cd
The push was also triggering wpt4 failures on credentialscontainer-create-basics.https.html TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password data - expected FAIL Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155091670&repo=autoland&lineNumber=1765
Thanks, NarcisB. Forgetting the secureContext.html test is sad but no big deal. I had no idea that we had wpts for Credential Management in-tree, so that's going to need its own bug to handle. Opened Bug 1429171.
Depends on: 1429171
Comment on attachment 8940907 [details] Bug 1428918 - Enable Web Authentication in Nightly https://reviewboard.mozilla.org/r/211168/#review217516 ::: security/manager/ssl/security-prefs.js:118 (Diff revision 2) > // 1: Only collect telemetry. CT qualification checks are not performed. > pref("security.pki.certificate_transparency.mode", 0); > > // Hardware Origin-bound Second Factor Support > pref("security.webauth.u2f", false); > +#ifdef RELEASE_OR_BETA (Ah, didn't recall we have RELEASE_OR_BETA, when there is also NIGHTLY_BUILD. I guess both work fine.)
Attachment #8940907 - Flags: review?(bugs) → review+
Thanks for the review, smaug! Oops, these need to be marked isSecureContext:true, too . Updating...  https://treeherder.mozilla.org/logviewer.html#?job_id=155345944&repo=try&lineNumber=9488
OK, this looks good now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=caf1e4f37ea8ad406df346b5cdf11931f9bdca9f&group_state=expanded Marking for checkin. With luck, no tree-burning this time!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2fb3a7563abc Enable Web Authentication in Nightly r=keeler,smaug
You need to log in before you can comment on or make changes to this bug.