Web Authentication - Pass or Disable the Credential Management WPTs

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jcj, Assigned: jcj)

Tracking

(Blocks 2 bugs)

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [webauthn] [webauthn-interop][credman])

Attachments

(1 attachment)

Assignee

Description

2 years ago
When enabling Web Authentication, we blew up credentialscontainer-create-basics.https.html :

TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() with bogus password data - expected FAIL

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=155091670&repo=autoland&lineNumber=1765

We need to resolve these tests somehow. This is blocking Bug 1428918.
Assignee

Updated

2 years ago
Blocks: 1428918
Assignee

Updated

2 years ago
Blocks: 1429196
Assignee

Updated

2 years ago
Assignee: nobody → jjones
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request)
Comment on attachment 8941178 [details]
Bug 1429171 - Enable portions of the Credential Management WPTs

https://reviewboard.mozilla.org/r/211442/#review217240

This seems reasonable to me, but I imagine we should get someone who's actually familiar with the web platform tests to review this.

::: testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini
(Diff revision 1)
>  
>    [navigator.credentials.create() with valid HTMLFormElement]
>      expected: FAIL
>  
> -  [navigator.credentials.create() with bogus password data]
> -    expected: FAIL

Do we want to remove these or are we supposed to change the 'FAIL' to a 'PASS' or something?
Attachment #8941178 - Flags: review?(dkeeler)
Assignee

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8941178 [details]
Bug 1429171 - Enable portions of the Credential Management WPTs

https://reviewboard.mozilla.org/r/211442/#review217240

Fair, thanks!

> Do we want to remove these or are we supposed to change the 'FAIL' to a 'PASS' or something?

We only need to change set an `expected` value if it's not supposed to be PASS, so judging by other tests, removal is the right thing to do here.
Comment hidden (mozreview-request)
Comment on attachment 8941178 [details]
Bug 1429171 - Enable portions of the Credential Management WPTs

https://reviewboard.mozilla.org/r/211442/#review217286
Attachment #8941178 - Flags: review?(james) → review+
Assignee

Comment 6

2 years ago
Thanks, James!

Try-run looks good now that whatever hiccup earlier went away: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ab6f1d38675077904f923603e8e6ac39f71dd93

So let's land this, and we can try Bug 1428918 again after.
Keywords: checkin-needed

Comment 7

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9de2146aba10 -d 6538de3b6137: rebasing 441606:9de2146aba10 "Bug 1429171 - Enable portions of the Credential Management WPTs r=jgraham" (tip)
merging testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini
merging testing/web-platform/meta/credential-management/idl.https.html.ini
warning: conflicts while merging testing/web-platform/meta/credential-management/credentialscontainer-create-basics.https.html.ini! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/web-platform/meta/credential-management/idl.https.html.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

2 years ago
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03920709eed2
Enable portions of the Credential Management WPTs r=jgraham
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/03920709eed2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.