1430411 - Don't include viewzoomoverlay.js

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Jan Henning [:JanH]]

No one in Fennec needs that file (https://dxr.mozilla.org/mozilla-central/search?q=viewzoomoverlay.js+-path%3Aobj-x86_64&redirect=false), not even after bug 1389829 because those "View Source"-related file are only required when showing the source in a new XUL window, while bug 1389829 will only ever open the source in a new tab.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds.

That file is only needed for desktop Firefox and when displaying the page source
in a separate window, which is a desktop-only feature as well.

Review commit: https://reviewboard.mozilla.org/r/212744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212744/

Comment 2

[Jan Henning [:JanH]]

Comment on attachment 8942452 [details]
Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212744/diff/1-2/

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8942452 [details]
Bug 1430411 - Exclude viewZoomOverlay.js from Fennec builds.

https://reviewboard.mozilla.org/r/212744/#review218590

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c0a6ed3bb7
Exclude viewZoomOverlay.js from Fennec builds. r=esawin

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/58c0a6ed3bb7