1430830 - regression: Icon jumps in dailymotion video player

Status: RESOLVED DUPLICATE of bug 1432541

(Core :: Graphics: WebRender, defect, P1)

Description

[noszalyaron4]

Attachment: 2018-01-16 18-14-11.flv

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180116100114

Steps to reproduce:

Enable webrender with the new gfx.webrender.all pref.
Navigating to any dailymotion video for example https://www.dailymotion.com/video/x6cz8z2


My gpu (sorry for hungarian, too lazy to set english system wide):
1. GPU
Aktív	Igen
Leírás	Intel Open Source Technology Center -- Mesa DRI Intel(R) HD Graphics 530 (Skylake GT2) 
Gyártóazonosító	Intel Open Source Technology Center
Eszközazonosító	Mesa DRI Intel(R) HD Graphics 530 (Skylake GT2) 
Illesztőprogram verziója	3.0 Mesa 17.2.2


Actual results:

When hovering over the player its full screen icon is rendered in the upper right corner, whereas it should be in the lower right corner. After some time it goes back to its right place.

Comment 1

[Darkspirit]

Thank you!

mozregression --good 2017-12-01 --bad 2018-01-13 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://www.dailymotion.com/video/x6cz8z2"
> 7:56.97 INFO: Last good revision: 27841347525c5e83a67e086d6fd15758c625a9e3
> 7:56.97 INFO: First bad revision: 92ff8af42f6fd6db6e7255b287031d6ec298e031
> 7:56.97 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27841347525c5e83a67e086d6fd15758c625a9e3&tochange=92ff8af42f6fd6db6e7255b287031d6ec298e031

> 92ff8af42f6f	Kartikaya Gupta — Bug 1422057 - Remove now-unnecessary ::Equals checks. r=mstange
> b8931ab9dac9	Kartikaya Gupta — Bug 1422057 - Deduplicate DisplayItemClipChain instances on creation. r=mstange
> e448dd0f4aba	Kartikaya Gupta — Bug 1422057 - Add hash function and boilerplate for deduplicating DisplayItemClipChain via std::set. r=mstange
> b65a65089ffb	Kartikaya Gupta — Bug 1422057 - Extend the clipchain of a display item to the ancestor's clipchain if it is a strict superset. r=mstange
> 78ca58c296fa	Kartikaya Gupta — Bug 1422057 - Extract a local variable. r=mstange
> c12c951b5ecc	Kartikaya Gupta — Bug 1422057 - Avoid caching clips across stacking contexts with non-identity transforms. r=mstange
> 4dcb02cef0b7	Kartikaya Gupta — Bug 1422057 - Adjust some logging-related things to be more useful. r=mstange

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I guess I should investigate this

Comment 3

[Kartikaya Gupta (email:[e-mail])]

So just to clarify, it looks like the fullscreen icon only goes up over top of the settings during the animation when the controls are showing or hiding. Once it is "stable" with the controls on-screen the view fixes itself.

Also it seems to me that my patch from bug 1432541 fixes this problem. At least I can reproduce the problem without that fix, and I can't any more with that fix applied. So I'm going to mark it as a dependency.

:darkspirit if you could verify on the try build from that bug that it fixes this problem for you as well that would be great. I suspect bug 1432742 and bug 1431326 might be in the same boat but I'm having a harder time reproducing those reliably so it's hard to say.

Comment 4

[Darkspirit]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)

try build from bug 1432541 comment 2:

mozregression --repo try --launch 7c443bd0fa3951123aa8b21c06cece0c8fb3b386 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://blog.fefe.de/|https://www.wikipedia.org/|https://www.mozilla.org/|https://www.dailymotion.com/video/x6cz8z2|about:newtab" browser.newtabpage.pinned:"[{\"url\":\"http://www.zeit.de/index\",\"label\":\"zeit\"}]"
* bug 1432742 tab title: good (only the non-wr bug is left)
* bug 1430830 dailymotion (after the ad!): good
* bug 1431326 tab loading icon: good
* about:support: WebRender is active

mozregression --launch 2018-01-24 --pref gfx.webrender.all:true startup.homepage_welcome_url:"https://blog.fefe.de/|https://www.wikipedia.org/|https://www.mozilla.org/|https://www.dailymotion.com/video/x6cz8z2|about:newtab" browser.newtabpage.pinned:"[{\"url\":\"http://www.zeit.de/index\",\"label\":\"zeit\"}]"
* bug 1432742 tab title: bad
* bug 1430830 dailymotion (after the ad!): bad
* bug 1431326 tab loading icon: bad
* about:support: WebRender is active

Tested multiple times.

lol?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Well, that's good. Less things to fix :)

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This should be fixed in today's nightly. Please reopen if you still see it.