1432239 - Sandbox MinGW Compilation errors: no matching function for call to operator new []

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tom Ritter [:tjr]]

0:02.57 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/sandbox/win/src/interception_agent.cc:114:62: error: no matching function for call to ‘operator new [](sizetype, sandbox::AllocationType, void*&)’
 0:02.57                   new(NT_PAGE, base_address) char[buffer_bytes]);

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1432239 Declare operator new [](size_t, sandbox::AllocationType, void*)

Review commit: https://reviewboard.mozilla.org/r/214666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214666/

Comment 2

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6966260d2d43

Comment 3

[Bob Owen (:bobowen)]

Comment on attachment 8944475 [details]
Bug 1432239 Declare operator new [](size_t, sandbox::AllocationType, void*)

https://reviewboard.mozilla.org/r/214666/#review220452

This made me nervous at first, but given the way this allocation works, I think this is OK.

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8944475 [details]
Bug 1432239 Declare operator new [](size_t, sandbox::AllocationType, void*)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214666/diff/1-2/

Comment 5

[Tom Ritter [:tjr]]

Patch Order: Bug 1432239 (this bug), Bug 1432295 , Bug 1432313

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3ddabc679cf
Declare operator new [](size_t, sandbox::AllocationType, void*) r=bobowen

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b3ddabc679cf