Closed
Bug 1431946
Opened 8 years ago
Closed 8 years ago
Move old utilityOverlay.js functions into SeaMonkey code
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.56 fixed)
RESOLVED
FIXED
seamonkey2.56
| Tracking | Status | |
|---|---|---|
| seamonkey2.56 | --- | fixed |
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file)
|
2.05 KB,
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1422721 +++
We've discovered that Firefox no longer uses various functions in utilityOverlay.js, and will be removing them in bug 1422720:
goSetMenuValue, goSetAccessKey, goOnEvent, setTooltipText
It looks like Thunderbird/SeaMonkey still use these, my guess is that they'd want to be in utilityOverlay.js, but I haven't tested that.
|
Assignee | |
Comment 1•8 years ago
|
||
Looks like a 1:1 patch from TB will do the trick.
|
|
Assignee | |
Updated•8 years ago
|
Blocks: 2.56BulkMalfunctions
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8944196 [details] [diff] [review]
1431946-globalfunctions.patch
LGTM, thanks.
Attachment #8944196 -
Flags: review?(stefanh) → review+
|
|
||
Comment 3•8 years ago
|
||
You might want to check if https://bugzilla.mozilla.org/show_bug.cgi?id=1422721#c10 should be ported as well.
|
|
Assignee | |
Comment 4•8 years ago
|
||
We seem to have this in suite/mailnews/addrbook/addressbook-panel.xul which already uses utilityoverlay.js.
|
|
||
Comment 5•8 years ago
|
||
Ah, ok.
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/34300ae56493
Copy goSetMenuValue(), goSetAccessKey(), goOnEvent() into suite after removal in Bug 1422720. r=stefanh
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Target Milestone: --- → Seamonkey2.56
You need to log in
before you can comment on or make changes to this bug.
Description
•