Clean-up sid handling in libssl

REOPENED
Assigned to

Status

P2
normal
REOPENED
10 months ago
9 months ago

People

(Reporter: franziskus, Assigned: franziskus)

Tracking

3.35

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
ssl_UncacheSessionID should free the session ID as well.
(Assignee)

Updated

10 months ago
Assignee: nobody → franziskuskiefer
Status: NEW → ASSIGNED
Priority: -- → P2
(Assignee)

Updated

10 months ago
See Also: → bug 1433644

Comment 1

10 months ago
Comment on attachment 8947031 [details]
Bug 1432144 - clean-up sid handling

Martin Thomson [:mt:] has approved the revision.

https://phabricator.services.mozilla.com/D517
Attachment #8947031 - Flags: review+
(Assignee)

Comment 2

10 months ago
https://hg.mozilla.org/projects/nss/rev/b33b017eede586be980efb9207e974f8ccf43509
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 3.36

Comment 3

9 months ago
Franziskus, I would like to back out this patch, and postpone the fix to a later NSS release. This will unblock the NSS 3.36 release, and will give us more time to have a clean fix for bug 1440588.

Do you agree?

Here's a Firefox try build with NSS tip and this patch backed out, it seems to be OK so far:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a1f65cdb9f71a0c92d7800d0697cbfdb7be9402

Here's a NSS try build with the patch backed out:
https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=5a89f9808a2141090eb12712de464d50cc79414a
Flags: needinfo?(franziskuskiefer)
(Assignee)

Comment 4

9 months ago
r+
Flags: needinfo?(franziskuskiefer)

Comment 5

9 months ago
Backed out
https://hg.mozilla.org/projects/nss/rev/f9e336b12cb4

Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 3.36 → ---
You need to log in before you can comment on or make changes to this bug.