1432229 - Land compare-locales 2.7 in mozilla-central

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Axel Hecht [:Pike]]

Once we have the new version of compare-locales, we'll need to land that and python-fluent 0.6 in-tree to be used by bug 1424682.

Heads up, we'd like to uplift this to 59 for cross-channel support.

Comment 1

[Axel Hecht [:Pike]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7689b34d68c2f4188fd3dbf9f63ecbd4c35ba621&selectedJob=160912351 is on its way through try.

It'd be nice to get some feedback on how that tree's doing with migrations etc.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

> Tt'd be nice to get some feedback on how that tree's doing with migrations etc.

Tested the patch against migrations from bug 1424682 and it all works flawlessly.

Comment 3

[Axel Hecht [:Pike]]

Attachment: bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,

Review commit: https://reviewboard.mozilla.org/r/218602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218602/

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,

https://reviewboard.mozilla.org/r/218602/#review224410

lgtm!

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218602/diff/1-2/

Comment 6

[Axel Hecht [:Pike]]

In the testing of python-fluent on our existing fluent projects, we discovered a bug that's fixed in fluent 0.6.2.

This passed on try in https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec03ed3651e261e62a75cbf904a8ff293c8c8cd3.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6604798c16d
land compare-locales 2.7 and python-fluent 0.6.2, r=gandalf

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

We'll want to request beta uplift for the following three bugs: bug 1426054, bug 1432229 and bug 1436790.

Reason: all three bugs are required to bring the updated version of new localization API (Fluent) to 0.6. Since we're using cross-channel for localization we'd like to start serializing our l10n to use 0.6 syntax in the localization tool (Pontoon).
Once we do, we'll need the updated parser in 59 to be able to read the output.

I'll request uplift for each patch separately, but placing them on the release mgmt radar together.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Sure, I'll track these for now, and please ask for beta uplift when you are ready.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b6604798c16d

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: we won't be able to take string updates for l10n
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no dependencies, but this blocks uplifts in bugs 1426054, 1436790
[Is the change risky?]: no
[Why is the change risky/not risky?]: Build-time only, and the code has already been tested to successfully read all our strings as part of a test install of transvision
[String changes made/needed]:

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,

Should land for the 59 beta 10 build. 
This looks like fun.

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c891235f733c