[CSD] LoadWidgetIconPixbuf should scale/reload titlebar button icons

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Bug 1408335 implements loading titlebar icons from themes, we need to also apply scale to them.
(Assignee)

Updated

a year ago
Assignee: nobody → stransky
(Assignee)

Updated

a year ago
Blocks: 1422276
(Assignee)

Comment 1

a year ago
We also should reload the icons when theme is changed.
(Assignee)

Updated

a year ago
Summary: [CSD] LoadWidgetIconPixbuf should scale icons → [CSD] LoadWidgetIconPixbuf should scale/reload titlebar button icons
(Assignee)

Comment 2

a year ago
We also need to refresh nsLookAndFeel and other modules here when theme changes.
(Assignee)

Comment 3

a year ago
nsLookAndFeel::RefreshImpl() should call WidgetCache refresh.
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8952387 [details]
Bug 1433068 - Reload WidgetstyleCache when theme changes,

https://reviewboard.mozilla.org/r/221636/#review227550
Attachment #8952387 - Flags: review?(jhorak) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8952388 [details]
Bug 1433068 - Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens,

https://reviewboard.mozilla.org/r/221638/#review227552

Looks good.
Attachment #8952388 - Flags: review?(jhorak) → review+

Comment 8

a year ago
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/76ab16daf148
Reload WidgetstyleCache when theme changes, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/280bf2bdcda1
Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens, r=jhorak

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76ab16daf148
https://hg.mozilla.org/mozilla-central/rev/280bf2bdcda1
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.