Closed Bug 1433068 Opened 5 years ago Closed 5 years ago

[CSD] LoadWidgetIconPixbuf should scale/reload titlebar button icons

Categories

(Core :: Widget: Gtk, enhancement, P2)

Product:
Core
Component:
Widget: Gtk
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1433068 - Reload WidgetstyleCache when theme changes,
59 bytes, text/x-review-board-request
jhorak
: review+
Details
Bug 1433068 - Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens,
59 bytes, text/x-review-board-request
jhorak
: review+
Details 
Bug 1408335 implements loading titlebar icons from themes, we need to also apply scale to them.
Assignee: nobody → stransky
We also should reload the icons when theme is changed.
Summary: [CSD] LoadWidgetIconPixbuf should scale icons → [CSD] LoadWidgetIconPixbuf should scale/reload titlebar button icons
We also need to refresh nsLookAndFeel and other modules here when theme changes.
nsLookAndFeel::RefreshImpl() should call WidgetCache refresh.
Comment on attachment 8952387 [details]
Bug 1433068 - Reload WidgetstyleCache when theme changes,

https://reviewboard.mozilla.org/r/221636/#review227550
Attachment #8952387 - Flags: review?(jhorak) → review+
Comment on attachment 8952388 [details]
Bug 1433068 - Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens,

https://reviewboard.mozilla.org/r/221638/#review227552

Looks good.
Attachment #8952388 - Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/76ab16daf148
Reload WidgetstyleCache when theme changes, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/280bf2bdcda1
Titlebar/Linux - load and draw HiDPI titlebar icons on HiDPI screens, r=jhorak
https://hg.mozilla.org/mozilla-central/rev/76ab16daf148
https://hg.mozilla.org/mozilla-central/rev/280bf2bdcda1
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.