1433230 - Add recent downloads to Highlights

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ed Lee :Mardak]

From https://github.com/mozilla/activity-stream/issues/3535

Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1354536 is reusing Activity Stream's Highlights queries to populate "Recent Activity" feature in the Library panel. The bug was originally filed as including downloaded items.

As we currently don't have downloads in Highlights, neither feature shows downloads.

Comment 1

[Ursula Sarracini (:ursula)]

uiwanted:
1. available context menu options for downloaded items
2. what happens when clicking on a downloaded item
3. what is the preview image for downloaded item
4. what is the description or tile of downloaded item
5. icons + strings
6. downloaded items since when? only the current session?

Comment 2

[Ursula Sarracini (:ursula)]

Invision designs: https://mozilla.invisionapp.com/share/VGGD0F4XR82#/screens

Comment 3

[Ciprian Muresan [:cmuresan], Ecosystem QA]

@Amy, will the "Show In Finder" string be used on Windows and Linux too?

Comment 4

[Ursula Sarracini (:ursula)]

@Ciprian, we're going to have platform specific strings :)

@Amy, there are still some outstanding questions around the behaviour of downloaded items in highlights:
1. Are we re-using the same frecency (5 days) for downloaded items to show up
2. What is the priority for Highlights now? As in, what's more important to show, Pocket vs Downloads vs Bookmarks vs History items
3. When we add/delete/change a downloaded item (at a system level - not just "dismiss" that card on newtab), how soon should that be reflected in Highlights? As soon as it happens? 5 minutes on the next update cycle?

Comment 5

[Amy Lee [:amylee] UX]

Hi Bryan, 

Can you provide some feed for the above questions? Thanks

Comment 6

[Amy Lee [:amylee] UX]

(In reply to Ciprian Muresan [:cmuresan], Desktop Engineering QA, :steve from comment #3)
> @Amy, will the "Show In Finder" string be used on Windows and Linux too?

The string for Windows/Linux is "Open Containing Folder"

Comment 7

[Amy Lee [:amylee] UX]

Trello card/Updated Spec https://trello.com/c/7AJYeOmj/182-recent-downloads-in-highlights

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4076

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e87a190e15becece8b98a3f49ccf55ffbe9baa1a
feat(highlights): Lazily add DownloadsManager view to handle recent downloads (#4076)

Fix Bug 1433230 - Add recent downloads to Highlights

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b

Comment 11

[Ed Lee :Mardak]

Strings landed for localization in https://github.com/mozilla/activity-stream-l10n/pull/15

Comment 12

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Build ID 	20180422223305
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have verified that the issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64. The most recent downloaded item is now displayed on the New Tab page.