1433488 - tweak ship-it v2 to `push` instead of `promote` for all Firefox/Devediton based on version number

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Work of this is being done in bug 1431799

Comment 2

[Aki Sasaki (not active)]

I didn't fix this in bug 1431799; let's fix this now.

Comment 3

[Aki Sasaki (not active)]

Attachment: bug 1433488 - auto-push firefox betas > b2.

Review commit: https://reviewboard.mozilla.org/r/222336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222336/

Comment 4

[Aki Sasaki (not active)]

I patched bm83 dev rr3, so our next maple fx beta > b2 should auto-push.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 8953064 [details]
bug 1433488 - auto-push firefox betas > b2.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222336/diff/1-2/

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8953064 [details]
bug 1433488 - auto-push firefox betas > b2.

https://reviewboard.mozilla.org/r/222336/#review228266

Comment 7

[Aki Sasaki (not active)]

Attachment: bug 1433488 - all firefox+devedition relpro actions need partial updates.

Review commit: https://reviewboard.mozilla.org/r/222370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222370/

Comment 8

[Aki Sasaki (not active)]

This is blocked by beetmover:

- beetmover gets its phase from the currently running relpro flavor
- the candidates beetmover task is generally filtered out from the push_firefox relpro flavor, because we already ran promote_firefox
- when we run push_firefox instead of promote_firefox, we have candidates beetmover tasks living with cdns beetmover tasks in the push_firefox graph
- beetmover candidates dies with the wrong payload, since we key off the phase for the payload.

Backing out from maple/dev-rr3 for now, until we can resolve this issue.

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 8953089 [details]
bug 1433488 - all firefox+devedition relpro actions need partial updates.

https://reviewboard.mozilla.org/r/222370/#review228292

Comment 10

[Aki Sasaki (not active)]

Attachment: bug 1433488 - require explicit shipping-phase in balrog+beetmover.

Review commit: https://reviewboard.mozilla.org/r/222386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222386/

Comment 11

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #8)
> This is blocked by beetmover:
> 
> - beetmover gets its phase from the currently running relpro flavor
> - the candidates beetmover task is generally filtered out from the
> push_firefox relpro flavor, because we already ran promote_firefox
> - when we run push_firefox instead of promote_firefox, we have candidates
> beetmover tasks living with cdns beetmover tasks in the push_firefox graph
> - beetmover candidates dies with the wrong payload, since we key off the
> phase for the payload.
> 
> Backing out from maple/dev-rr3 for now, until we can resolve this issue.

I may have fixed this... testing on maple; submitted to review.

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 8953102 [details]
bug 1433488 - require explicit shipping-phase in balrog+beetmover.

https://reviewboard.mozilla.org/r/222386/#review228304

Comment 13

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #11)
> (In reply to Aki Sasaki [:aki] from comment #8)
> > This is blocked by beetmover:
> > 
> > - beetmover gets its phase from the currently running relpro flavor
> > - the candidates beetmover task is generally filtered out from the
> > push_firefox relpro flavor, because we already ran promote_firefox
> > - when we run push_firefox instead of promote_firefox, we have candidates
> > beetmover tasks living with cdns beetmover tasks in the push_firefox graph
> > - beetmover candidates dies with the wrong payload, since we key off the
> > phase for the payload.
> > 
> > Backing out from maple/dev-rr3 for now, until we can resolve this issue.
> 
> I may have fixed this... testing on maple; submitted to review.

I think there's still some magic in scriptworker.py that changes behavior based on phase. Let's back this entire bug out for now.

Comment 14

[Aki Sasaki (not active)]

I haven't been working on this since comment 13. Not sure how high of a priority or want this is?
We were blocked by shipping-phase needing to be explicitly defined in the beetmover and balrog tasks. This may have already happened.

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

We must have solved this somewhere elsewhere to get automated betas, right ? We go straight to ship_firefox flavor for that.

Comment 16

[Aki Sasaki (not active)]

+1.