143472 - Host sort order in "Password Manager" should be done by Top Level Domain on down

Status: NEW

(SeaMonkey :: Passwords & Permissions, defect, P3)

Description

[Eric Vaandering (no email)]

The corrolary to bug 142179 and bug 143166, which describes this behavior for
cookie management and image managment.

Sorting by .com first, then cnn.com, then server1.cnn.com etc is a much more
intuitive and useful way to sort lists of hostnames and makes it much easier for
the user to manage their privacy.

A patch (untested) for 142179 exists, than patch plus a bit of work should fix
this bug too.

Comment 1

[John L. Villalovos]

Attachment: Fix for password manager sorting

Here is a patch to make the sorting in password manager be done by TLD on down.


One issue I did notice with this patch is that I have a couple password entries
like:

site.com (Site Information)
site.com:80 (Site Information)
site.com

Unfortunately they don't get sorted correctly because of the additional stuff
after the ".com" part.	I'll work on modifying the original patch in bug 142179
so that maybe there is a parameter or default behavior to strip off any
trailing information for the sorting column.  Stripping off stuff would not
affect what is displayed only how it is sorted.

Comment 2

[John L. Villalovos]

The patch also updates the sorting for the "Form Manager" since it is handled by
the same chunk of code.

Comment 3

[John Villalovos]

With the updated patch in bug 142179 the sorting will now handle the sites that
have ports and/or site information as mentioned in comment 1

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to new module owner

Comment 5

[Urban A. Haas]

I see this was implemented for Cookies, but not for password manager. Is this ever going to see the light of day?

Urban

Comment 7

[Robert Kaiser]

The new Data Manager lists all data by effective toplevel domain, so the ultimate switch to it fixes this.