Closed Bug 1435181 Opened 2 years ago Closed 2 years ago

Migration should warn about unknown FTL entities in add_transforms()

Categories

(Localization Infrastructure and Tools :: Fluent Migration, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: stas)

Details

Attachments

(1 file)

I was trying to test locally bug 1424683, but the migration came out empty. It turns out, the FTL.Identifier was mispelled.

The migration code should warn when a migration is not found in the FTL file.
Depends on: 1435183
No longer depends on: 1435183
That could create a log of noise for incomplete locales. Are you OK with that?
Flags: needinfo?(francesco.lodolo)
I'm not sure we're talking about the same issue.

The migration had

id=FTL.Identifier('brand-short-name'),

while the FTL had -brand-short-name (message vs term), resulting in an empty migration.

Is it possible to warn in such cases, i.e. the term is not available in the source en-US file?
Flags: needinfo?(francesco.lodolo)
Ah, I see now! Thanks for the clarification. It should be doable, I'll see what I can do.
Attached file Pull Request
Assignee: nobody → stas
Status: NEW → ASSIGNED
Fixed in https://github.com/projectfluent/python-fluent/commit/cb318cb39ca8c9a2ddf559a84ed2b620a616028e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
No longer blocks: fluent.migrate
Component: Python Library → Fluent Migration
Product: L20n → Localization Infrastructure and Tools
You need to log in before you can comment on or make changes to this bug.